Last modified: 2012-01-12 00:51:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16586, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 14586 - Inputbox Always includes Main namespace
Inputbox Always includes Main namespace
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
InputBox (Other open bugs)
unspecified
PC Linux
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-06-18 20:08 UTC by Phil Moors
Modified: 2012-01-12 00:51 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Phil Moors 2008-06-18 20:08:40 UTC 
<inputbox>
type=search
namespaces=Custom**
</inputbox>

The above does create an inputbox with the Custom namespace checked. But the results page returned is flooded with hits from the Main namespace.

MediaWiki  	1.12.0
PHP 	5.1.6 (cgi-fcgi)
MySQL 	5.0.27

The end of the results page url from InputBox looks like:

../index.php?search=blast&ns100=1&fulltext=Search+full+text

However, when I do a restricted search from the system search box, the results are correct and the url is different:

../index.php?ns100=1&search=blast&searchx=Search
Comment 1 Phil Moors 2008-06-20 15:47:28 UTC 
Found a way to get the behavior I wanted:

In line 145 of inputbox.php, change:

    name="fulltext"
to
    name="searchx"

Don't know if that's the 'proper' fix, though.
Comment 2 Siebrand Mazeland 2008-08-13 19:56:42 UTC 
Keywords: patch, need-review

The patch in comment 2 is on line 144 per r38195.
Comment 3 Mark A. Hershberger 2011-06-14 00:22:35 UTC 
unassigned Trevor from Inputbox extension.
Comment 4 Sumana Harihareswara 2012-01-11 00:21:41 UTC 
Phil, can you still reproduce this issue?
Comment 5 Robin Pepermans (SPQRobin) 2012-01-12 00:51:02 UTC 
I can't reproduce the problem in 1.18 or trunk, and the code has changed a lot since 2008 anyway, so I'm closing this bug.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links