Last modified: 2012-02-28 20:46:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16582, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 14582 - #globalWrapper class is not applied correctly when specific page content is entered
#globalWrapper class is not applied correctly when specific page content is e...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.12.x
PC Windows XP
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-18 11:25 UTC by Alexander Obuhovich
Modified: 2012-02-28 20:46 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshots how it is broken and how it should be. (90.17 KB, application/zip)
2008-06-18 11:26 UTC, Alexander Obuhovich
Details

Description Alexander Obuhovich 2008-06-18 11:25:36 UTC
Class #globalWrapper in main.css doesn't get applied to menu in Monobook skin (left page part, where sidebar is drawn), when page is consitent of such text:

--------- Bad Page: BEGIN --------------------------
* list element {{TipBox|tip content}}
--------- Bad Page: END --------------------------

--------- TipBox Template: BEGIN-------------------
<div>
bad div thing
</div>
--------- TipBox Template: END-------------------
Please review 2 screenshots attached (in zip file). Red circles indicate where is problem in layout. Green circles indicate what layout should be.
Comment 1 Alexander Obuhovich 2008-06-18 11:26:34 UTC
Created attachment 4998 [details]
screenshots how it is broken and how it should be.
Comment 2 Alexander Obuhovich 2008-06-19 17:28:10 UTC
I've compare resulting HTML:

---------- GOOD: BEGIN ----------------
<ul><li> list element <div>bad div thing</div>
</li></ul>
---------- GOOD: END ----------------

---------- BAD: BEGIN ----------------
<ul><li> list element <div>
</li></ul>
<p>bad div thing
</p>
</div>
---------- BAD: END ----------------

Enter after div (in bad case) becomes list end and div closing element (</div>) are places after closing list element (</ul>). I think this is some kind of fundamental (because wiki-text is based on enters very much) problem and can't be easily fixed :(
Comment 3 Danny B. 2008-06-22 11:18:13 UTC
Two ways to fix:

Use either HTML markup for list, thus

<ul>
<li>list element {{TipBox|tip content}}</li>
</ul>

or do not wrap lines in the template content, thus

<div>bad div thing</div>
Comment 4 Alexander Obuhovich 2008-06-22 19:48:37 UTC
2nd look good for me. 10x

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links