Last modified: 2008-08-14 08:20:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14581 - Make UI easier with diff-only preference
Make UI easier with diff-only preference
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
Depends on:
  Show dependency treegraph
Reported: 2008-06-18 10:52 UTC by P. Birken
Modified: 2008-08-14 08:20 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description P. Birken 2008-06-18 10:52:04 UTC
If you set "Do not show page content below diffs" in the preferences, you do not see the flagging box. However, you get the same message as the others, as can be seen in the screenshot. So, either it should be explained how to do that (click on draft, use the box on the bottom) or we add the flagging box also in this case. 

Personally, I now favour the last option. The reason is that with flagging of templates and local images enabled, the chance of vandalism of that sort has dropped significantly. Together with a warning about unsighted template changes, that should be enough and is actually a feature wish of many users.
Comment 1 Aaron Schulz 2008-06-18 14:03:43 UTC
Done in r36417
Comment 2 P. Birken 2008-06-23 18:42:49 UTC
Mh, what's the problem with the second option of showing the box?
Comment 3 P. Birken 2008-07-03 19:43:57 UTC
I though some more on this: the problem with this one is that then, people will get the one click sighting no matter what preference they chose and some people will not want this. Therefore, there should be the possivility in the flagged revisions preferences to turn one click sighting off. 
Comment 4 P. Birken 2008-07-07 19:11:51 UTC
OK, so here is the final thought :-)

The combination of the preference "Do not show page content below diffs" with flagged revisions is rather unnatural. Instead, the following is much better: As default, enable one-click-sighting for editors. Add a preference in the flagged revisions section to disable that and furthermore, add a preference to disable the box for flagging completely. 

This would mean that people could chose how much they want to get involved in the process of sighting edits: Only by an automatic process, a bit or a lot. And by chosing the default as the maximal involvement, I hope that we will get this to scale much better. Currently, you often have the situation that editors edit after a noneditor but do not sight the whole thing. 
Comment 5 Aaron Schulz 2008-07-14 15:07:01 UTC
Further improve in r37649. Diff after edit suppresses the preference.
Comment 6 P. Birken 2008-07-26 14:24:14 UTC
It's still that way that if I enable Misc->Do not show page content below diffs, then one-click-sighting is disabled. 
Comment 7 Aaron Schulz 2008-07-26 18:14:57 UTC
What diff links cause that? The flagged revs UI links should point to &diffonly=0, unless overridden locally, in which case Sysops should tweak the messages.
Comment 8 Aaron Schulz 2008-07-27 02:33:29 UTC
Looks like a local message issue. These should be updated.
Comment 9 Aaron Schulz 2008-07-27 02:33:39 UTC
Looks like a local message issue. These should be updated.
Comment 10 P. Birken 2008-07-27 17:15:42 UTC
Ah, I apparently wasn't thorough. Thanks for improving this a lot! The problem is still caused by difflinks like, where the box appears in the one case and doesn't in the other. What about the additional preferences I mentioned?
Comment 11 Aaron Schulz 2008-08-01 17:38:25 UTC
I don't want the preferences to start getting bloated here. I'd rather everyone have the box and diff.

As for the diff links that are not from the flaggedrevs UI, like the one above, I'd rather not change the behavior there, since it would be unexpectedly overriding the user's preferences.
Comment 12 P. Birken 2008-08-03 20:02:43 UTC
With the possibility of flagging templates, the chance of getting vandalism from "outside", meaning from templates or pictures is so small, that there's no real reason not to make one-click-sighting available to everybody. So, the solution would be not to show the whole article and the box in the diff above, but to show the box in both cases and the article only if set in the user's preferences. 
Comment 13 Aaron Schulz 2008-08-14 08:20:12 UTC
Done in r39330

Note You need to log in before you can comment on or make changes to this bug.