Last modified: 2005-02-04 00:38:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3458, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 1458 - Previewing appears to have submitted
Previewing appears to have submitted
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
PC Linux
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/w/index.php?t...
:
: 610 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-02-03 08:11 UTC by J'raxis
Modified: 2005-02-04 00:38 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description J'raxis 2005-02-03 08:11:59 UTC
Previewing edits seems to have somehow actually SUBMITTED them:

# 07:42, 2005 Feb 3 (hist) (diff) User:J'raxis (Added "missing" notice, Arabic
form.)  (top)
# 07:40, 2005 Feb 3 (hist) (diff) User:J'raxis (Added "missing" notice, Arabic
form.)
# 07:39, 2005 Feb 3 (hist) (diff) User:J'raxis (Added "missing" notice, Arabic
form.)
# 07:37, 2005 Feb 3 (hist) (diff) User:J'raxis (Added "missing" notice, Arabic
form.)
# 07:36, 2005 Feb 3 (hist) (diff) User:J'raxis (Added "missing" notice, Arabic
form.)
# 07:36, 2005 Feb 3 (hist) (diff) User:J'raxis
# 07:35, 2005 Feb 3 (hist) (diff) User:J'raxis (Added "missing" notice, Arabic
form.)

Each of these other than the topmost was caused by me previewing. I believe I
previewed it more times than what you see here, so preview isn't ALWAYS causing
an actual submit. I'm not sure if this is reproduceable, as I don't want to make
a mess of any page histories trying to reproduce it.

[This is NOT a duplicate of bug 1263, which I submitted some time ago, about
dupe entries showing up in page histories, although it may be related: the
server was being extremely slow while I was previewing.]

Additionally, is there any way this edit history can be cleaned up? Ironically,
I was in the process of adding a note to my user page about why I've disappeared
from Wikipedia recently: because of the difficulty in editing anything without
the server being impossibly slow, logging me out in the middle of an edit thus
not attributing the edit to me, or creating dupe entries. Now with this
ridiculous-looking mess made of my user history, if it can't be fixed, I'm
thinking of calling it quits completely.
Comment 1 Brion Vibber 2005-02-03 09:27:47 UTC
Could be a problem with post data being cut off partway through, missing the submission info that indicates 
it's a preview. That's consistent with for instance this diff:
http://en.wikipedia.org/w/index.php?title=User:J%27raxis&diff=9907156&oldid=9907152

Will take a look...
Comment 2 J'raxis 2005-02-03 17:02:30 UTC
Yeah, that's probably it. I think I hit stop a few times during the previews
because it was being so slow. Perhaps not having wpSave as the default action
would be a good idea in a future version of MediaWiki. wpSave as default also
has the mildly irritating effect of causing a premature submit if one
accidentally hits enter in the summary box, something I've also done a few times.

[Mildly OT, but where do I ask about having a Sysop cleanup this revision
history? Last time I had a request like this, I eventually found some help pages
at either Wikipedia proper or the Meta site that said to email a Sysop who has
DB write access, but I never got responses from those whom I emailed.]
Comment 3 Brion Vibber 2005-02-03 19:43:46 UTC
I've made a fix to force preview mode if the form submission is incomplete (indicated by wpEdittime, the very 
last field on the form, not being set). I believe this should be sufficient to prevent saves on partial form 
submissions.

When the submission is complete, save needs to be implicitly assumed when neither wpSave nor wpPreview is 
present in order to allow saving by hitting enter from the summary box or checkboxes. (This is intentional, as 
every other form submission on the web works like that.)

I'll clean up those stray entries from the database shortly...
Comment 4 Zigger 2005-02-03 23:39:47 UTC
*** Bug 610 has been marked as a duplicate of this bug. ***
Comment 5 Brion Vibber 2005-02-04 00:00:35 UTC
Have removed the reported bogus intermediate revisions from 7:35 through 7:40.
Comment 6 Richard J. Holton 2005-02-04 00:38:46 UTC
I wonder if this bug could be related to #275: Page or section content
duplication on edit conflict with self.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links