Last modified: 2014-06-26 20:26:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14562 - UNIQ key exposed when feeding strip markers into {{#tag:source
UNIQ key exposed when feeding strip markers into {{#tag:source
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Bawolff (Brian Wolff)
http://en.wikipedia.org/wiki/User:Aza...
:
Depends on:
Blocks: UNIQ 14959
  Show dependency treegraph
 
Reported: 2008-06-16 17:22 UTC by Carl Fürstenberg
Modified: 2014-06-26 20:26 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Carl Fürstenberg 2008-06-16 17:22:24 UTC
If an <nowiki> and firends is used inside an function, then instead of generating a result, the UNIQ key is exposed instead, for example: "{{#tag:source|<nowiki>foo</nowiki>|lang=java}}" gives UNIQ7f095fb854002218-nowiki-00000000-QINU in one instance.
Comment 1 Aaron Schulz 2008-09-12 14:41:05 UTC
I can repro with cite tags too
Comment 2 Tim Starling 2008-09-12 14:44:49 UTC
The convention is that text inserted into the unstrip array should be fully unstripped already. This is because unstrip() is a performance hotspot, much more common than strip item insertion, so it makes sense to perform as much of the processing as possible during insertion.
Comment 3 Mark A. Hershberger 2010-12-02 20:20:56 UTC
Confirmed this with the latest SyntaxHighlight_GeSHi and SVN HEAD, but not with Cite.
Comment 4 Mark A. Hershberger 2011-04-12 16:37:12 UTC
Re-classifying as a SyntaxHighlight_GeSHi problem.  It should be fixed there, not in core MW.
Comment 5 Mark A. Hershberger 2011-05-03 17:43:16 UTC
Assigning to robla since this is a "high" priority and X!'s user page says he is extremely busy IRL as of 17:57, 20 March 2011 (UTC)
Comment 6 Tim Starling 2011-07-07 07:03:51 UTC
Why is it a high priority?
Comment 7 Mark A. Hershberger 2011-07-07 14:23:14 UTC
(In reply to comment #6)
> Why is it a high priority?

These sort of niggling little problems are piling up.  Perhaps this particular one is something that we can live without fixing RIGHT now, but AFAICT, this and other dependencies of Bug #26213 are going to keep coming until we have something to tell authors to look for when trying to solve the problem or to test for when writing new code.
 
The priority was set after a triage that said deployed extensions are higher priority.  This bug is on a deployed extension.  See http://www.mediawiki.org/wiki/User:MarkAHershberger/BugDemo#Bug_14562  Also on that page, a demonstration of Bug #22555 which is a problem with ParserFunctions and can also be seen on Wikipedia: http://en.wikipedia.org/wiki/User:MarkAHershberger/Bug_Examples#Bug_14562

Reading back through the reports it is clear that some users think their wikitext is at fault ('basically a big flashing sign that says "BAD WIKICODE HERE".')

Ideally, I'd like to do a sprint to fix Bug #26213.  This bug is a good place to start.
Comment 8 Rob Lanphier 2011-07-07 17:19:45 UTC
Mark and I discussed this one.  This bug is going to low priority, because it's relatively minor, but there is some UNIQ cleanup work that could be high priority.
Comment 9 Gerrit Notification Bot 2014-06-20 20:45:28 UTC
Change 141056 had a related patch set uploaded by Brian Wolff:
Prevent OutputPage::addWikiText and friends from causing UNIQ fails

https://gerrit.wikimedia.org/r/141056
Comment 10 Gerrit Notification Bot 2014-06-26 09:25:23 UTC
Change 141056 merged by jenkins-bot:
Prevent OutputPage::addWikiText and friends from causing UNIQ fails

https://gerrit.wikimedia.org/r/141056
Comment 11 Nemo 2014-06-26 19:36:24 UTC
Approved by Nikerabbit and translatewiki.net didn't explode.
Comment 12 Bawolff (Brian Wolff) 2014-06-26 20:26:30 UTC
whoops, what am I doing. This one has a different cause for the UNIQ's. That patch won't fix it.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links