Last modified: 2008-11-20 10:29:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14561 - Draft tab does not disappear after sighting
Draft tab does not disappear after sighting
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Aaron Schulz
:
: 14963 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-16 14:53 UTC by P. Birken
Modified: 2008-11-20 10:29 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description P. Birken 2008-06-16 14:53:48 UTC
A lot of users report that the draft tab does not disappear after them sighting an article manually. Purging the article or waiting does help, so it might be a cache issue.
Comment 1 Melancholie 2008-06-16 17:35:43 UTC
This also applies for changed page contents (even after logged in edits), by the way!
Heavy caching?
Comment 2 Christoph Burgmer 2008-06-17 17:04:46 UTC
This sucks big time. Please increase severity/priority or refrain from using this extension on dewiki.

That's what you see:
http://img294.imageshack.us/img294/509/wikipediasichtensj9.png
See #14510.
Comment 3 Aaron Schulz 2008-06-17 19:41:24 UTC
(In reply to comment #1)
> This also applies for changed page contents (even after logged in edits), by
> the way!
> Heavy caching?
> 

OK, I can reproduce this through autosighting on .de, rollback too.
Comment 4 Aaron Schulz 2008-06-17 19:48:40 UTC
Seems sporadic as well.
Comment 5 P. Birken 2008-06-17 19:55:35 UTC
Yes, it's definitely not the norm, but the exception. 
Comment 6 Aaron Schulz 2008-06-21 03:10:15 UTC
Does this still occur?
Comment 7 P. Birken 2008-06-23 18:05:48 UTC
I had this once today, also an error where [[de:Mars (Planet)]] was sighted at 9:55, but was listed on Special:OldReviewedPages for 8 hours. But things seem to have improved. 
Comment 8 P. Birken 2008-06-24 11:45:26 UTC
Just now there is an occurence in http://de.wikipedia.org/wiki/Schenk%C3%B6konomie. In that case, it is combined with the changed image http://de.wikipedia.org/wiki/Bild:Produktdifferenzierung_1._Ordnung.png. However, after flagging the new version of that picture, the draft tab is still there, also after flagging the article itself anew. 

By the way: the images/templates that have been changed are no longer mentioned in the diff. Is that a bug?
Comment 9 Aaron Schulz 2008-06-24 14:37:40 UTC
That could easily be jobqueue lag. Seems to be fine now.
Comment 10 Tim Landscheidt 2008-07-04 03:30:08 UTC
I have a similar (?) problem with three pictures whose review form's oldid does not reference the newest revision so they remain in "Outdated reviewed pages" limbo:

[[:de:Bild:Freising domkrypta bestiensaeule.jpg]]: oldid=34260172, should be 34722745.
[[:de:Bild:Hamburg Areal Stadtdeich-Bankstraße-Schleusenstraße.JPG]]: oldid=33716891, should be 33717289.
[[:de:Bild:Griechisches Relief.jpg]]: oldid=34147990, should be 34198865.

I looks like "upload revisions" are ignored.
Comment 11 Aaron Schulz 2008-07-04 09:24:30 UTC
The upload code may not be setting page_latest.
Comment 12 Aaron Schulz 2008-07-06 11:12:30 UTC
Also, as to #10:

The upload code and import code used to not update page_latest. I remember fixing that a while ago, but the last image revision was a year ago, so that was probably before the fix. A small edit should work.
Comment 13 P. Birken 2008-07-07 18:59:53 UTC
There was an occasion today in http://de.wikipedia.org/wiki/Konrad_Adenauer. 
Comment 14 Aaron Schulz 2008-07-08 00:05:47 UTC
(In reply to comment #13)
> There was an occasion today in http://de.wikipedia.org/wiki/Konrad_Adenauer. 
> 

Was this immediately after sighting of the page itself?
Comment 15 Tim Landscheidt 2008-07-08 05:30:30 UTC
(In reply to comment #12)
> The upload code and import code used to not update page_latest. I remember
> fixing that a while ago, but the last image revision was a year ago, so that
> was probably before the fix. A small edit should work.

You hit it right on the head. After a small edit, everything was fine. A "nulledit" ("Edit", then "Save" without any changes) did not work though.

Would it make sense to scan (and correct) automatically the database for such cases once to get the database up to par with the code's premises? Without having a deeper insight into MediaWiki, I assume incorrect page_latests will have other side effects as well.
Comment 16 Tim Landscheidt 2008-07-08 22:23:04 UTC
Hmmm. On the other side, [[:de:Bild:Stasi-statue.jpg]]'s history shows that the latest revision *is* sighted, still it shows "Artikel / Entwurf / Diskussion" and "Ungesichtete Version / [letzte gesichtete Version] / (vergleiche)".
Comment 17 Tim Landscheidt 2008-07-11 06:22:48 UTC
Same problem with [[:de:Elektrizitätswerk Minden-Ravensberg]]. Would it be possible for the extension to dump some (non-sensitive) debug information in HTML comments so that tracking down those bugs would become easier? At the moment, this feels rather futile.
Comment 18 Aaron Schulz 2008-07-11 17:58:26 UTC
You can check the HTML of the form. The [x]Params fields give useful info.
Comment 19 Aaron Schulz 2008-07-27 02:35:08 UTC
Some tweaks were made a few days ago for this. Still not quite sure where the problem starts.
Comment 20 Aaron Schulz 2008-07-28 20:53:20 UTC
*** Bug 14963 has been marked as a duplicate of this bug. ***
Comment 21 Aaron Schulz 2008-08-01 17:34:46 UTC
Any new instances?
Comment 22 P. Birken 2008-08-04 11:42:28 UTC
Just now two new occurences in http://de.wikipedia.org/wiki/Wilhelm_Bendow and http://de.wikipedia.org/wiki/Ritterorden. 
Comment 23 Aaron Schulz 2008-08-04 11:47:23 UTC
(In reply to comment #22)
> Just now two new occurences in http://de.wikipedia.org/wiki/Wilhelm_Bendow and
> http://de.wikipedia.org/wiki/Ritterorden. 
> 

That is a more recent unrelated bug. This bug is for pages that say "template/image" changes when there are in fact none.
Comment 24 Aaron Schulz 2008-08-04 22:02:29 UTC
Hmm, 'Kaiser-Wilhelm-Nationaldenkmal' seems to be an example.

Berlin_Kaiser_Wilhelm_I_Denkmal_um_1900.jpg is not matched. Maybe the problem is just in the diff code.
Comment 25 Aaron Schulz 2008-08-04 22:10:33 UTC
This is a commons image, would explain the issue. The diff query wouldn't hit it. Since the cause of this bug was already isolated to images, this seems to be the problem then. It is the diff, not the page, that is off. Not sure how to go about fixing the diff. 
Comment 26 Aaron Schulz 2008-08-05 15:53:43 UTC
Should be fixed in r38631,r38635

Old pages that had this issue will still have bad caches.
Comment 27 Tim Landscheidt 2008-11-20 10:17:18 UTC
I found a new instance at http://de.wikipedia.org/wiki/Bild:Viannos.png. There is no draft tab, but a "unsighted version/last sighted version/diff" link. If you view the diff link (http://de.wikipedia.org/w/index.php?title=Bild:Viannos.png&oldid=52790749&diff=cur&diffonly=0), no differences are shown. Also the page history shows that the image was created 11 days ago with only one upload so it should not be due to the page_latest bug. Neither clicking "Markierung speichern" nor nulledits solve the issue.
Comment 28 Aaron Schulz 2008-11-20 10:29:47 UTC
page_latest issue. Fixed with a whitespace edit. Note that there were 2 page edits at the time, which is where the page_latest bug emerges. The # of file revisions doesn't matter.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links