Last modified: 2008-06-16 02:27:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14551 - "Cancel upload" on Special:Upload shouldn't check "ignore any warnings" button
"Cancel upload" on Special:Upload shouldn't check "ignore any warnings" button
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-15 21:42 UTC by RockMFR
Modified: 2008-06-16 02:27 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Special:Upload patch (option 1) (470 bytes, patch)
2008-06-15 21:58 UTC, RockMFR
Details

Description RockMFR 2008-06-15 21:42:47 UTC
On the upload warning page for Special:Upload, clicking "Cancel upload and return to the upload form" should not result in the "Ignore any warnings" checkbox being checked. Just because the user sees one warning doesn't mean they shouldn't get any more!

There are three legitimate ways that I see to fix this:

1) When checking $this->mReUpload, if it is true, then set $this->mIgnoreWarning to false.
2) Split the form on the upload warning page into two forms: one for the ignore warning button and one for the cancel upload button.
3) Have the ignore warning button on the upload warning page use something else besides wpUpload (i.e., wpUploadNoWarnings).
Comment 1 RockMFR 2008-06-15 21:58:35 UTC
Created attachment 4979 [details]
Special:Upload patch (option 1)

Going with option #1 as it is the easiest...
Comment 2 Chad H. 2008-06-16 01:47:16 UTC
Done in r36317.

I did it slightly different. Instead, I took the value of $this->mIgnoreWarning as a value for future warnings.
Comment 3 RockMFR 2008-06-16 02:02:43 UTC
Actually, I don't think that will work. Because the rest of the code treats it as a checkbox, it is considered true if a value is submitted at all, even if it is just empty.
Comment 4 Chad H. 2008-06-16 02:04:49 UTC
What about:

$uploadWarningBool = 0
if ( $this->mIgnoreWarnings ) $uploadWarningBool = 1;
...
...
Xml::hidden( 'wpIgnoreWarning', $uploadWarningBool ) . "\n" .
Comment 5 RockMFR 2008-06-16 02:11:10 UTC
Nope, because it doesn't matter what the previous setting of mIgnoreWarnings was once you get to the warning page. At that point, it will be false all the time.
Comment 6 Chad H. 2008-06-16 02:27:05 UTC
You're right, I was trying to overthink it. Done in r36318 by your original patch.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links