Last modified: 2008-06-20 19:15:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14512 - Add link trail on Slavic "ů" character
Add link trail on Slavic "ů" character
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://szl.wikipedia.org/w/index.php?...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-12 12:56 UTC by Mike Połtyn
Modified: 2008-06-20 19:15 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mike Połtyn 2008-06-12 12:56:25 UTC
At the moment, Slavic diacritic "ů" is making link trails end.

I.e. "[[śilńik]]ům" will produce clickable "śilńik" with nor linked "ům" ending.

Other Slavic diacritics are used in Czech language and are working fine, the problem is only made by this ů letter.
Comment 1 Huji 2008-06-12 22:11:43 UTC
I suggest adding this to languages/messages/MessagesSzl.php

$linkTrail = '/^([a-zů]+)(.*)$/sDu';

However, I'm not applying it myself, because I think it may be retouched (like, other characters be added too).
Comment 2 Danny B. 2008-06-12 23:47:02 UTC
Fixed in r36250.
Comment 3 Daniel Friesen 2008-06-13 02:50:36 UTC
Amended in r36250.

I've fixed the base default to accept all unicode alpha characters. Rather than specifying a few characters for individual languages, this should mean that all characters work in all languages. (Pending deletion of legacy $linkTrail definitions from some other locale files.
Comment 4 Daniel Friesen 2008-06-13 03:04:10 UTC
Oh right... You can see this over at:
http://dev.wiki-tools.com/purge/Link_Codes

I have a demoing setup to set the content language just use:
http://langcode.dev.wiki-tools.com/purge/Link_Codes

So for this locale here:
http://szl.dev.wiki-tools.com/purge/Link_Codes
Comment 5 Daniel Friesen 2008-06-13 03:39:11 UTC
Ah crap... Sorry bad paste... My amended revision is r36253 and r36254.
Comment 6 Huji 2008-06-13 09:55:39 UTC
Actually, Daniel, I'm not sure if what you did has no side effects; I can recall an old discussion with Brion, where he told me about side effects of having all these linktrail stuff handled by En, so I'm adding him to the CC list. He knows better than I do.
Comment 7 Daniel Friesen 2008-06-13 10:12:44 UTC
Well, a conversation in irc between Me, Splarka, and Tim yielded the view that it's best if linktrail is done in a locale independent manor (apparently word diff already is), sans the few language exceptions which would be overridden per-language if they had some sort of unlikely fatal error.

I've been hunting through the various languages. 90% of the characters added in $linkTrail overrides is covered by the default. Though, likely I'm going to have to put some of that inside of a constant or two and use that in a method of creating an override for a few languages that use things like » inside of their linktrail.
Comment 8 Brion Vibber 2008-06-20 19:15:35 UTC
The main trick with locale-independent linktrails is that some languages don't use word spacing (or don't use it consistently, or don't use it the way we do), meaning that they shouldn't have trails extended. Luckily they're usually in their own writing systems -- Chinese, Thai, and such -- allowing us to treat them as such in a mixed-language environment.

Considering mixed-language text, we need to make sure that trails don't extend unexpectedly when a link abuts text in another language.

The other oddity is that a couple languages currently specify some quote characters for their linkprefix and linkTrail (such as cv), so a link that appears in quotes will expand to include them. I'm not sure how proper that is to do.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links