Last modified: 2008-06-06 08:32:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16430, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 14430 - Can't turn off "further results" with format=embedded
Can't turn off "further results" with format=embedded
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Markus Krötzsch
http://sandbox.semantic-mediawiki.org...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-06-06 07:31 UTC by S Page
Modified: 2008-06-06 08:32 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description S Page 2008-06-06 07:31:44 UTC 
User CNIT commented that |searchlabel=| doesn't work to turn off further results link with format=embedded.

I verified, and it's a trivial fix, the test in SMW_QP_Embedded.php doesn't match that in SMW_QP_{List,Table,Template}

-		if ( $this->mInline && $res->hasFurtherResults() ) {
+		if ( $this->mInline && $res->hasFurtherResults() && $this->mSearchlabel !== '') {
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links