Last modified: 2008-06-06 08:32:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14430 - Can't turn off "further results" with format=embedded
Can't turn off "further results" with format=embedded
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Markus Krötzsch
Depends on:
  Show dependency treegraph
Reported: 2008-06-06 07:31 UTC by S Page
Modified: 2008-06-06 08:32 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description S Page 2008-06-06 07:31:44 UTC
User CNIT commented that |searchlabel=| doesn't work to turn off further results link with format=embedded.

I verified, and it's a trivial fix, the test in SMW_QP_Embedded.php doesn't match that in SMW_QP_{List,Table,Template}

-		if ( $this->mInline && $res->hasFurtherResults() ) {
+		if ( $this->mInline && $res->hasFurtherResults() && $this->mSearchlabel !== '') {

Note You need to log in before you can comment on or make changes to this bug.