Last modified: 2005-04-13 17:11:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1442 - ISBN in image description generates invalid HTML
ISBN in image description generates invalid HTML
Status: RESOLVED DUPLICATE of bug 1887
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/w/index.php?t...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-01-31 20:03 UTC by blackchar
Modified: 2005-04-13 17:11 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description blackchar 2005-01-31 20:03:08 UTC
Basically MediaWiki generates an <A HREF...> link 
for the ISBN leading to a "special" page. This 
link is retained as part of the image alt-text 
(created based on the description). Of course, 
having a link inside ALT attribute is not 
healthy. Some HTML code spills out of the tag 
onto the page.

You can see the problem at the link provided with 
this bug entry (I saw it in Opera 8, but I guess 
most browsers should work the same here).
Comment 1 T. Gries 2005-01-31 21:11:19 UTC
We should not use such offensive languages here.
Comment 2 Duncan Harris 2005-04-07 15:20:07 UTC
It is easy not to include ISBNs in image captions.
Comment 3 Ævar Arnfjörð Bjarmason 2005-04-12 10:50:30 UTC
The problem is that Parser::magicISBN() is called after Linker::makeThumbLinkObj
has been run on the text, which means that the magicISBN function will expand on
any ISBN number it recognizes, including those inside XHTML tags like alt="" or
title="".
Comment 4 Rowan Collins [IMSoP] 2005-04-13 12:40:35 UTC
(In reply to comment #3)
> The problem is that Parser::magicISBN() is called after Linker::makeThumbLinkObj
> has been run on the text, which means that the magicISBN function will expand on
> any ISBN number it recognizes, including those inside XHTML tags like alt="" or
> title="".

In that case, it should be possible to do things the other way round, since the
image code should strip the HTML tags back out of the alt/title attributes. Kind
of ugly, but I think it might work.
Comment 5 Ævar Arnfjörð Bjarmason 2005-04-13 17:11:10 UTC

*** This bug has been marked as a duplicate of 1887 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links