Last modified: 2010-05-15 15:38:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3441, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 1441 - Cleanup PageHistory.php watchlist lookup


Summary:	Cleanup PageHistory.php watchlist lookup

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	History/Diffs (Other open bugs)
Version:	1.5.x
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-01-31 16:05 UTC by Zigger
Modified:	2010-05-15 15:38 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patches PageHistory.php for HEAD (1.29 KB, patch) 2005-01-31 16:06 UTC, Zigger	Details
Add an attachment (proposed patch, testcase, etc.)

Description Zigger 2005-01-31 16:05:14 UTC

1. Displaying a page history as an anonymous user or as a user without the page on
   their watchlist produces a PHP message on the page:
   "Notice: Trying to get property of non-object in
W:\www\head\includes\PageHistory.php on line 64"
   (Using PHP 5.0.0 with E_ALL)

2. A higher-level database class function can be used which avoids the above
message.

3. The watchlist lookup could use DB_SLAVE instead of DB_MASTER.

4. The watchlist lookup can be avoided completely if there is no user-id.

Patch to follow ...

Comment 1 Zigger 2005-01-31 16:06:12 UTC

Created attachment 241 [details]
Patches PageHistory.php for HEAD

Comment 2 JeLuF 2005-01-31 16:51:58 UTC

Fixed in HEAD, rev 1.56

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links