Last modified: 2010-05-15 15:38:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1441 - Cleanup PageHistory.php watchlist lookup
Cleanup PageHistory.php watchlist lookup
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
  Show dependency treegraph
Reported: 2005-01-31 16:05 UTC by Zigger
Modified: 2010-05-15 15:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Patches PageHistory.php for HEAD (1.29 KB, patch)
2005-01-31 16:06 UTC, Zigger

Description Zigger 2005-01-31 16:05:14 UTC
1. Displaying a page history as an anonymous user or as a user without the page on
   their watchlist produces a PHP message on the page:
   "Notice: Trying to get property of non-object in
W:\www\head\includes\PageHistory.php on line 64"
   (Using PHP 5.0.0 with E_ALL)

2. A higher-level database class function can be used which avoids the above

3. The watchlist lookup could use DB_SLAVE instead of DB_MASTER.

4. The watchlist lookup can be avoided completely if there is no user-id.

Patch to follow ...
Comment 1 Zigger 2005-01-31 16:06:12 UTC
Created attachment 241 [details]
Patches PageHistory.php for HEAD
Comment 2 JeLuF 2005-01-31 16:51:58 UTC
Fixed in HEAD, rev 1.56

Note You need to log in before you can comment on or make changes to this bug.