Last modified: 2008-06-06 16:36:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14401 - Hotkeys in Safari Mac
Hotkeys in Safari Mac
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
http://trac.webkit.org/changeset/34259
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-04 01:01 UTC by Derk-Jan Hartman
Modified: 2008-06-06 16:36 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
new tooltipAccessKeyPrefix'es for newer Safari versions. (1.46 KB, patch)
2008-06-04 01:24 UTC, Derk-Jan Hartman
Details
updated patch with fixed is_safari_win detection (1.43 KB, patch)
2008-06-04 13:38 UTC, Derk-Jan Hartman
Details

Description Derk-Jan Hartman 2008-06-04 01:01:45 UTC
The Safari developers have decided to change the accesskey modifiers. This will require an additional case in wikibits.js.

The new modifier keys are ctrl-option (or ctrl-alt) and they are active in at least WebKit 527 and higher.

var match = navigator.userAgent.match(/AppleWebKit\/(\d+)/);
  if (match) {
    var webKitVersion = parseInt(match[1]);
    if (webKitVersion < 420)
}

I'll try to make a patch for this.
Comment 1 Derk-Jan Hartman 2008-06-04 01:24:14 UTC
Created attachment 4954 [details]
new tooltipAccessKeyPrefix'es for newer Safari versions.

This patch adds checks for applewebkit version and safari windows, allowing accurate tooltips for the accesskeys.
Comment 2 Derk-Jan Hartman 2008-06-04 13:38:05 UTC
Created attachment 4955 [details]
updated patch with fixed is_safari_win detection

I made a type. Corrected.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-06-05 22:13:03 UTC
Did you test this patch?  If so, on what versions of Safari?  Also, in your patch, it seems like is_safari_win falls back to the "alt-" prefix for all versions, which is an unmentioned change from current behavior.  Is this correct?
Comment 4 Brion Vibber 2008-06-06 01:49:11 UTC
A quick behavior check to confirm the required hotkey to trigger "edit":

* Mac/Safari 3.1: control+e
	Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_3; en-us) AppleWebKit/525.18 (KHTML, like Gecko) Version/3.1.1 Safari/525.20

* Mac/Webkit nightly: control+option+e
	Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_3; en-us) AppleWebKit/527+ (KHTML, like Gecko) Version/3.1.1 Safari/525.20

* Win/Safari 3.1: alt+e
	Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/525.13 (KHTML, Like Gecko) Version/3.1 Safari/525.13

* Win/Webkit nightly: alt+e
	Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/526+ (KHTML, like Gecko) Version/3.1 Safari/525.13


Tabs are labeled correctly with the patch; applied on r35961.
Comment 5 Derk-Jan Hartman 2008-06-06 08:51:47 UTC
Thanks for confirming trough the tests brion. I had indeed forgotten to mention that Safari windows users were already seeing an incorrecte label from the inception of the Safari Windows version.
Comment 6 Brion Vibber 2008-06-06 16:36:47 UTC
Thanks for the patch! :D

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links