Last modified: 2010-05-15 15:54:48 UTC
Created attachment 4951 [details]
Patch from 03.06.2008
Here will be some changes I made to my MediaWiki (wecowi.org)
Maybe something could be useful for MediaWiki Development
Only take a quick look, feedback or questions are welcome
Created attachment 4952 [details]
Patch from 03.06.2008
Sry wrong file
What does your patch fix? Some description would be nice :)
Could you please provide a patch w/o the whitespace changes, it makes a review harder. Thanks a lot.
Created attachment 4993 [details]
Version without spaces
maybe the sources should always be cleaned of space, like my editor do
Sure I'll explain
1. I made generate Sitemap work with the server option
it is used in the Sitemap Index an in the sitemaps, so for example for my wiki I generate the sitemap with another domain for each week
2. Removed fixed sizes from editbuttons so that smaller version could be included through a gadget
3. Made Option to disable ulimit.sh
On my Wiki it does not work with ulimit
Raimond, can you please review the patch and advise?
(In reply to comment #5)
> Raimond, can you please review the patch and advise?
Sorry, but someone else should review.
What are the changes in main.css for? Are you certain this is a clean patch?
the changes in main.css are for displaying skype: links like irc: links
(In reply to comment #8)
> the changes in main.css are for displaying skype: links like irc: links
Yes, obviously. But why would that be in a patch called "Patch for generateSitemap.php"? Can you please ensure to deliver a clean patch?
I don't know why this patch is named that way
Soembody changed it to that or the attaching of the diff file had changed the name
what does it mean a clean patch?
this was ment to be to but all changes for the Web Community Wiki together, to show what I've changed and then the developers could choose which of my changes are useful or not
(In reply to comment #10)
> this was ment to be to but all changes for the Web Community Wiki together, to
> show what I've changed and then the developers could choose which of my changes
> are useful or not
Ah. That's a certain recipe for a patch to never be applied. You will have the highest succes rate submitting individual functionalities, fixes, or bugs in individual bugs.
Given your above explanation, I think this patch should be a WONTFIX.
okay, not my problem, just tried to show what I`ve changes, when there is nobody interested in it, then not
in my version there are these changes, so it's not for me
seams that I solved the problem that is given there, but nobody listens to my, not my problem
*** This bug has been marked as a duplicate of bug 9675 ***
*** Bug 14336 has been marked as a duplicate of this bug. ***