Last modified: 2010-05-15 15:54:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14397 - Patch for generateSitemap.php
Patch for generateSitemap.php
Status: RESOLVED DUPLICATE of bug 9675
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.12.x
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks: 14336
  Show dependency treegraph
 
Reported: 2008-06-03 19:25 UTC by DaSch
Modified: 2010-05-15 15:54 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch from 03.06.2008 (2.20 KB, patch)
2008-06-03 19:25 UTC, DaSch
Details
Patch from 03.06.2008 (33.28 KB, patch)
2008-06-03 19:28 UTC, DaSch
Details
Version without spaces (6.57 KB, patch)
2008-06-17 21:05 UTC, DaSch
Details

Description DaSch 2008-06-03 19:25:40 UTC
Created attachment 4951 [details]
Patch from 03.06.2008

Here will be some changes I made to my MediaWiki (wecowi.org)
Maybe something could be useful for MediaWiki Development
Only take a quick look, feedback or questions are welcome
Comment 1 DaSch 2008-06-03 19:28:22 UTC
Created attachment 4952 [details]
Patch from 03.06.2008

Sry wrong file
Comment 2 Raimond Spekking 2008-06-17 20:43:59 UTC
What does your patch fix? Some description would be nice :)

Could you please provide a patch w/o the whitespace changes, it makes a review harder. Thanks a lot.
Comment 3 DaSch 2008-06-17 21:05:26 UTC
Created attachment 4993 [details]
Version without spaces

maybe the sources should always be cleaned of space, like my editor do
Comment 4 DaSch 2008-06-17 21:08:30 UTC
Sure I'll explain
1. I made generate Sitemap work with the server option
it is used in the Sitemap Index an in the sitemaps, so for example for my wiki I generate the sitemap with another domain for each week
2. Removed fixed sizes from editbuttons so that smaller version could be included through a gadget
3. Made Option to disable ulimit.sh
On my Wiki it does not work with ulimit
Comment 5 Siebrand Mazeland 2008-08-16 23:15:21 UTC
Raimond, can you please review the patch and advise?
Comment 6 Raimond Spekking 2008-09-10 06:28:45 UTC
(In reply to comment #5)
> Raimond, can you please review the patch and advise?
> 

Sorry, but someone else should review.
Comment 7 Siebrand Mazeland 2008-11-03 22:00:40 UTC
What are the changes in main.css for? Are you certain this is a clean patch?
Comment 8 DaSch 2008-11-04 16:00:29 UTC
the changes in main.css are for displaying skype: links like irc: links
Comment 9 Siebrand Mazeland 2008-11-04 16:58:51 UTC
(In reply to comment #8)
> the changes in main.css are for displaying skype: links like irc: links

Yes, obviously. But why would that be in a patch called "Patch for generateSitemap.php"? Can you please ensure to deliver a clean patch?

Comment 10 DaSch 2008-11-04 17:15:26 UTC
I don't know why this patch is named that way

Soembody changed it to that or the attaching of the diff file had changed the name

what does it mean a clean patch?

this was ment to be to but all changes for the Web Community Wiki together, to show what I've changed and then the developers could choose which of my changes are useful or not
Comment 11 Siebrand Mazeland 2008-11-04 19:09:08 UTC
(In reply to comment #10)
> this was ment to be to but all changes for the Web Community Wiki together, to
> show what I've changed and then the developers could choose which of my changes
> are useful or not

Ah. That's a certain recipe for a patch to never be applied. You will have the highest succes rate submitting individual functionalities, fixes, or bugs in individual bugs.

Given your above explanation, I think this patch should be a WONTFIX. 

Comment 12 DaSch 2008-11-04 19:17:22 UTC
okay, not my problem, just tried to show what I`ve changes, when there is nobody interested in it, then not

in my version there are these changes, so it's not for me
Comment 13 DaSch 2008-12-21 12:34:43 UTC
seams that I solved the problem that is given there, but nobody listens to my, not my problem

*** This bug has been marked as a duplicate of bug 9675 ***
Comment 14 DaSch 2009-02-24 14:14:34 UTC
*** Bug 14336 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links