Last modified: 2008-06-02 23:25:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14382 - Wrong number of "changes need review"
Wrong number of "changes need review"
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Aaron Schulz
http://de.labs.wikimedia.org/w/index....
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-02 22:58 UTC by Raimond Spekking
Modified: 2008-06-02 23:25 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Raimond Spekking 2008-06-02 22:58:50 UTC
In FlaggedArticle.php line 227 (r35701):

$revsSince = FlaggedRevs::getRevCountSince( $this->parent, $frev->getRevId() );

It seems that FlaggedRevs::getRevCountSince() return ever 1. See above URL: 3 edits were done but the message says "1 change awaits review."
Comment 1 Aaron Schulz 2008-06-02 23:11:29 UTC
I don't see anything wrong with that line
Comment 2 Raimond Spekking 2008-06-02 23:17:38 UTC
Maybe I have picked the wrong line, but do you see the difference on the page?

http://de.labs.wikimedia.org/w/index.php?title=Allgemeine_und_Anorganische_Chemie:_Komplexreaktionen&stable=0&shownotice=1&uselang=en

"The latest sighted revision (list all) was approved on 2 June 2008. 1 change needs review."

Click on "1 change" and you get a diff between 3 revisions (= 2 intermediate revisions):

http://de.labs.wikimedia.org/w/index.php?title=Allgemeine_und_Anorganische_Chemie:_Komplexreaktionen&oldid=22550&diff=cur&uselang=en

Comment 3 Aaron Schulz 2008-06-02 23:25:00 UTC
Fixed in r35766

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links