Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16367, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 14367 - Don't watch user page when blocking was not sucessful

Summary:	Don't watch user page when blocking was not sucessful

Status: RESOLVED FIXED Product: MediaWiki Classification: Unclassified Component: User blocking (Other open bugs) Version: 1.13.x Hardware: All All Importance: Normal normal (vote) Target Milestone: --- Assigned To: Chad H. URL: Whiteboard: Keywords: Depends on: Blocks:   Show dependency tree / graph		Reported: 2008-05-31 20:15 UTC by Adrian Lang Modified: 2010-05-15 16:03 UTC (History) CC List: 0 users See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Quick fix for this, against r35759 (836 bytes, patch) 2008-06-02 20:36 UTC, Chad H. Details Add an attachment (proposed patch, testcase, etc.)

Description Adrian Lang 2008-05-31 20:15:47 UTC If an error (user already blocked, wrong time format, user doesn't exist, ...) occurs while blocking a user and wpWatchUser is true, the user page is added to the watchlist. IMHO this should only apply if the user was blocked successfully. Comment 1 Chad H. 2008-06-02 20:36:30 UTC Created attachment 4945 [details] Quick fix for this, against r35759 Quick patch to implement this. Should've done this originally when I wrote the feature. Now runs after BlockIpComplete, so we know we completed correctly and didn't abort. Comment 2 Brion Vibber 2008-06-02 21:53:14 UTC Applied on r35763