Last modified: 2008-06-05 14:52:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16347, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 14347 - SpecialUserlogin::onCookieRedirectCheck misses obscure case when using CentralAuth
SpecialUserlogin::onCookieRedirectCheck misses obscure case when using Centra...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Tim Starling
:
: 14383 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-05-30 17:55 UTC by Bryan Tong Minh
Modified: 2008-06-05 14:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bryan Tong Minh 2008-05-30 17:55:54 UTC 
When using CentralAuth SpecialUserlogin::onCookieRedirectCheck is useless:
* Consider you login without an appropriate session cookie set
* Your login succeeds and you get the appropriate UserId, UserName and session token
* You are then redirected using wpCookieCheck which will trigger a check on your session cookie
* Everything is ok so the UserLoginComplete will trigger
* As there is no proper session attached, $wgUser will contain an anonymous user. CentralAuthHooks::onUserLoginComplete will run on that
* CentralAuth will do undefined stuff and you will get the messsage 'You are now logged in to Meta as "83.81.x.y"'
Comment 1 Bryan Tong Minh 2008-05-30 17:59:30 UTC 
Easy way to reproduce this behaviour:

* Use FireFox and install the "View Cookies" add-on
* Goto Special:Userlogin
* Delete your session cookie
* Login
Comment 2 Brion Vibber 2008-05-30 21:25:08 UTC 
The check works correctly for me for its primary purpose:

* Clear & disable cookies in browser
* http://en.wikipedia.org/w/index.php?title=Special:UserLogin&returnto=Main_Page
* put in username/pass and hit 'Log in'
* "Login error: Wikipedia uses cookies to log in users. You have cookies disabled. Please enable them and try again."

Tested in Safari 3.1.
Comment 3 Bryan Tong Minh 2008-05-30 21:28:04 UTC 
Yes, but not when you only clear your cookies after you've reached Special:Userlogin, but do not disable them. Should be extremely rare though.
Comment 4 Brion Vibber 2008-06-02 23:37:31 UTC 
*** Bug 14383 has been marked as a duplicate of this bug. ***
Comment 5 Iaroslav Vassiliev 2008-06-03 00:16:06 UTC 
This problem arises, if user has been browsing the web with cookies disabled, then he goes to login page, enables cookies, enters his password and... fails.
Comment 6 Tim Starling 2008-06-05 14:52:34 UTC 
Should be fixed in r35932
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links