Last modified: 2010-05-15 16:03:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14328 - jsMsg should accept DOM objects as input
jsMsg should accept DOM objects as input
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
  Show dependency treegraph
Reported: 2008-05-29 08:40 UTC by Adrian Lang
Modified: 2010-05-15 16:03 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Adrian Lang 2008-05-29 08:40:43 UTC
currently, jsMsg only takes HTML as String for the message content.

I suggest the following change:

<	messageDiv.innerHTML = message;

>	if (typeof message == 'string') {
>		messageDiv.innerHTML = message;
>	}
>	else if (typeof message == 'object') {
>		while (messageDiv.hasChildNodes()) // Remove old content
>			messageDiv.removeChild(messageDiv.firstChild);
>		messageDiv.appendChild (message); // Append new content
>	}
Comment 1 Chad H. 2008-06-12 14:01:19 UTC
Fixed in r36239

Note You need to log in before you can comment on or make changes to this bug.