Last modified: 2008-08-10 18:33:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14294 - PATCHES - moving Wikimedia only stuff from LanguageXx.php to InitialiseSettings.php
PATCHES - moving Wikimedia only stuff from LanguageXx.php to InitialiseSettin...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Language setup (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-27 14:28 UTC by Danny B.
Modified: 2008-08-10 18:33 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Removing Wikimedia only stuff from LanguageCs.php, + some doc (2.92 KB, patch)
2008-05-27 14:28 UTC, Danny B.
Details
Moving Wikimedia only stuff to InitialiseSettings (wgGrammarForms) (7.18 KB, text/plain)
2008-05-27 14:30 UTC, Danny B.
Details
wgGrammarForms for 'be' (1.25 KB, patch)
2008-08-08 19:42 UTC, Siebrand Mazeland
Details
wgGrammarForms for 'be-tarask' (1.27 KB, patch)
2008-08-08 20:12 UTC, Siebrand Mazeland
Details
wgGrammarForms for 'bs' (1.73 KB, patch)
2008-08-08 20:31 UTC, Siebrand Mazeland
Details
Cleanup for LanguageBs.php after wgGrammarForms for 'bs' (3.19 KB, patch)
2008-08-08 20:32 UTC, Siebrand Mazeland
Details
wgGrammarForms for 'dsb' (1.46 KB, patch)
2008-08-08 20:52 UTC, Siebrand Mazeland
Details
wgGrammarForms for 'hsb' (1.46 KB, patch)
2008-08-08 20:52 UTC, Siebrand Mazeland
Details
Cleanup for LanguageDsb.php after wgGrammarForms for 'dsb' (2.68 KB, patch)
2008-08-08 20:54 UTC, Siebrand Mazeland
Details
wrong (1.04 KB, text/plain)
2008-08-08 20:54 UTC, Siebrand Mazeland
Details
Cleanup for LanguageHsb.php after wgGrammarForms for 'hsb' (2.68 KB, patch)
2008-08-08 20:57 UTC, Siebrand Mazeland
Details
Cleanup for LanguageBe.php after wgGrammarForms for 'be' (2.27 KB, patch)
2008-08-08 21:31 UTC, Siebrand Mazeland
Details
Cleanup for LanguageBe_tarask.php after wgGrammarForms for 'be-tarask' (2.31 KB, patch)
2008-08-08 21:31 UTC, Siebrand Mazeland
Details

Description Danny B. 2008-05-27 14:28:56 UTC
Created attachment 4930 [details]
Removing Wikimedia only stuff from LanguageCs.php, + some doc

Per bug 14165 moving Wikimedia only stuff from LanguageCs.php to InitialiseSettings.php.

The patch to LanguageCs.php must not be applied before the patch to InitialiseSettings.php is done, otherwise live wikis will loose the proper {{grammar:}} function
Comment 1 Danny B. 2008-05-27 14:30:33 UTC
Created attachment 4931 [details]
Moving Wikimedia only stuff to InitialiseSettings (wgGrammarForms)
Comment 2 Siebrand Mazeland 2008-08-08 19:42:36 UTC
Created attachment 5135 [details]
wgGrammarForms for 'be'

Adding $wgGrammarForms for 'be'. Should be removed from LanguageBe.php after configuration.
Comment 3 Siebrand Mazeland 2008-08-08 20:12:58 UTC
Created attachment 5136 [details]
wgGrammarForms for 'be-tarask'
Comment 4 Siebrand Mazeland 2008-08-08 20:31:15 UTC
Created attachment 5137 [details]
wgGrammarForms for 'bs'

Also see LanguageBs.php.patch to cleanup LanguageBs.php after using this configuration.
Comment 5 Siebrand Mazeland 2008-08-08 20:32:17 UTC
Created attachment 5138 [details]
Cleanup for LanguageBs.php after wgGrammarForms for 'bs'
Comment 6 Siebrand Mazeland 2008-08-08 20:52:42 UTC
Created attachment 5139 [details]
wgGrammarForms for 'dsb'
Comment 7 Siebrand Mazeland 2008-08-08 20:52:56 UTC
Created attachment 5140 [details]
wgGrammarForms for 'hsb'
Comment 8 Siebrand Mazeland 2008-08-08 20:54:08 UTC
Created attachment 5141 [details]
Cleanup for LanguageDsb.php after wgGrammarForms for 'dsb'
Comment 9 Siebrand Mazeland 2008-08-08 20:54:17 UTC
Created attachment 5142 [details]
wrong
Comment 10 Siebrand Mazeland 2008-08-08 20:57:22 UTC
Created attachment 5143 [details]
Cleanup for LanguageHsb.php after wgGrammarForms for 'hsb'
Comment 11 Siebrand Mazeland 2008-08-08 21:31:35 UTC
Created attachment 5144 [details]
Cleanup for LanguageBe.php after wgGrammarForms for 'be'
Comment 12 Siebrand Mazeland 2008-08-08 21:31:51 UTC
Created attachment 5145 [details]
Cleanup for LanguageBe_tarask.php after wgGrammarForms for 'be-tarask'
Comment 13 Siebrand Mazeland 2008-08-09 13:52:38 UTC
Brion suggested a different, probably better solution, that is also much easier for Wikimedia shell operators: add all this stuff to the extension WikimediaMessages, and as a consequence, remove the section 'wgGrammarForms' from http://noc.wikimedia.org/conf/InitialiseSettings.php.html.

I have already made all necessary changes to files on my local system. Will discuss this on IRC when brion, Tim, or JeLuF is available. 
Comment 14 Siebrand Mazeland 2008-08-10 18:33:56 UTC
Fixed in r39077.

* (bug 14165, bug 14294) Wikimedia specific configuration in convertGrammar() for 13 localisations (be, be-tarask, bs, cs, dsb, ga, gsw, hsb, hu, lv, rmy, sk, sl) removed. The settings have been put in extension WikimediaMessages. For be, be-tarask, bs, dsb, hsb some duplicates (1=1) were removed. Patch for Czech by Danny B.
* Also put the wgGrammarForms from the Wikimedia configuration in here, so everything is in one place. Bonus with this setup is that there will be a little less work for Wikimedia shell operators, as the wgGrammarForms configuration is now accessible to i18n committers.
* Header for WikimediaMessages.php, and add myself to extension credits.

WARNING to Wikimedia shell operators: the whole section "wgGrammarForms" in InitialiseSettings.php.html should be remove after updating to this version. It will most probably overrule all settings in WikimediaMessages because of "'default' => array()"

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links