Last modified: 2009-09-29 17:22:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14238 - Navigation links, categories and {{PAGENAME}} are the ones of the Main_Page, if only ?diff= is given
Navigation links, categories and {{PAGENAME}} are the ones of the Main_Page, ...
Status: RESOLVED DUPLICATE of bug 15233
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
unspecified
All All
: Normal normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://meta.wikimedia.org/wiki/?diff=...
:
: 14297 14437 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-23 16:24 UTC by Katie Chan
Modified: 2009-09-29 17:22 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Katie Chan 2008-05-23 16:24:53 UTC
When viewing a diff via a URL which only contain the diff number, the resulting page link to the main page rather than the page for which the diff occurred in.
Comment 1 Huji 2008-05-24 19:50:21 UTC
This doesn't happen if both "diff" and "oldid" are present in the URL; this only happens when only "diff" is given and "diffonly" is set to "yes".
Comment 2 Huji 2008-05-24 20:40:00 UTC
It looks like when the "oldid" value is not present, the default value of 0 is used, which falls back to Main Page. The diff itself works correctly because in DifferenceEngine.php we have:

  elseif ( $this->mOldid === 0 ) {
    $rev = $this->mNewRev->getPrevious();
    if( $rev ) {
      $this->mOldid = $rev->getId();

So the oldid used for the diff is corrected, but that being used to create the content_actions is equal to zero.

I couldn't find where exactly this oldid is being used to create the content_actions link relating to the page itself; once it is located, using an approach similar to what I posted above can solve the bug.
Comment 3 Brion Vibber 2008-05-27 17:38:34 UTC
*** Bug 14297 has been marked as a duplicate of this bug. ***
Comment 4 Charlotte Webb 2008-05-27 18:37:43 UTC
> This doesn't happen if both "diff" and "oldid" are present in the URL; this
> only happens when only "diff" is given and "diffonly" is set to "yes".
> 

Maybe this is why I thought the bug had been fixed and un-fixed. I recently changed my prefs to diffonly by default. Sorry for duplicate 14297.
Comment 5 Katie Chan 2008-05-28 10:17:20 UTC
(In reply to comment #1)
> This doesn't happen if both "diff" and "oldid" are present in the URL; this
> only happens when only "diff" is given and "diffonly" is set to "yes".
> 

The above first sentence is correct, but not the second. This does happen even when diffonly is not set. The casuse is when oldid is not set.
Comment 6 Katie Chan 2008-06-06 15:20:12 UTC
*** Bug 14437 has been marked as a duplicate of this bug. ***
Comment 8 Alexandre Emsenhuber [IAlex] 2009-09-29 17:22:14 UTC

*** This bug has been marked as a duplicate of bug 15233 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links