Last modified: 2008-06-20 18:41:28 UTC
The extension "Cite" offers <ref> & <references /> tags and an attribution "group" for usage. However, the value of the attribution "group" can not be DBCS characters. I think supporting DBCS characters will be more friendly and convenient for those users in CJK.
now ,write code: <ref group="註">some notes</ref> it render HTML: <sup id="_ref-4" class="reference"><a href="#_note-4" title="">[.E8.A8.BB 1]</a></sup> please change to: <sup id="_ref-4" class="reference"><a href="#_note-4" title="">[註 1]</a></sup>
when write: <references group="註" /> it render nothing.
Created attachment 4995 [details] fix group display please apply this patch
str_replace( ' ', '_',$argv['group']) don't need. pls patch below: Index: Cite_body.php =================================================================== --- Cite_body.php (revision 36127) +++ Cite_body.php (working copy) @@ -202,7 +202,7 @@ if ( isset( $argv['group'] ) ){ if (! $wgAllowCiteGroups ) return array(false); //remove when groups are fully tested. // Group given. - $group = $this->validateName( $argv['group'] ); + $group = $argv['group'];//don't apply validateName for group display unset( $argv['group']); --$cnt; }
Created attachment 4996 [details] update update delete str_replace(' ','_',$)
Applied on r36431.
Could you also add a parser test case for this to citeParserTests.txt?
Created attachment 5005 [details] add parser test case for chinese groupname !! test Simple <ref>, with <references/> in group, with groupname in chinese !! input AAA<ref group="参">ref a</ref>BBB<ref group="注">note b</ref>CCC<ref group="参">ref c</ref> ;refs <references group="参" /> ;notes <references group="注" /> !! result <p>AAA<sup id="cite_ref-0" class="reference"><a href="#cite_note-0" title="">[参 1]</a></sup>BBB<sup id="cite_ref-1" class="reference"><a href="#cite_note-1" title="">[注 1]</a></sup>CCC<sup id="cite_ref-2" class="reference"><a href="#cite_note-2" title="">[参 2]</a></sup> </p> <dl><dt>refs </dt></dl> <ol class="references"><li id="cite_note-0"><a href="#cite_ref-0" title="">↑</a> ref a</li> <li id="cite_note-2"><a href="#cite_ref-2" title="">↑</a> ref c</li></ol> <dl><dt>notes </dt></dl> <ol class="references"><li id="cite_note-1"><a href="#cite_ref-1" title="">↑</a> note b</li></ol> !! end
Thanks! Committed as r36513
