Last modified: 2008-06-20 18:41:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14216 - Grouping references does not support DBCS characters
Grouping references does not support DBCS characters
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Cite (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-22 04:45 UTC by 百楽兎
Modified: 2008-06-20 18:41 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
fix group display (529 bytes, patch)
2008-06-18 03:24 UTC, fdcn
Details
update (507 bytes, patch)
2008-06-18 05:04 UTC, fdcn
Details
add parser test case for chinese groupname (1.20 KB, patch)
2008-06-20 02:50 UTC, fdcn
Details

Description 百楽兎 2008-05-22 04:45:00 UTC
The extension "Cite" offers <ref> & <references /> tags and an attribution "group" for usage. However, the value of the attribution "group" can not be DBCS characters. I think supporting DBCS characters will be more friendly and convenient for those users in CJK.
Comment 1 fdcn 2008-05-22 13:41:52 UTC
now ,write code:
<ref group="註">some notes</ref>

it render HTML:
<sup id="_ref-4" class="reference"><a href="#_note-4" title="">[.E8.A8.BB 1]</a></sup>

please change to:
<sup id="_ref-4" class="reference"><a href="#_note-4" title="">[註 1]</a></sup>
Comment 2 fdcn 2008-05-22 13:47:10 UTC
when write:
<references group="註" />

it render nothing.
Comment 3 fdcn 2008-06-18 03:24:51 UTC
Created attachment 4995 [details]
fix group display

please apply this patch
Comment 4 fdcn 2008-06-18 03:56:46 UTC
str_replace( ' ', '_',$argv['group']) don't need. pls patch below:

Index: Cite_body.php
===================================================================
--- Cite_body.php	(revision 36127)
+++ Cite_body.php	(working copy)
@@ -202,7 +202,7 @@
 			if ( isset( $argv['group'] ) ){
 				if (! $wgAllowCiteGroups ) return array(false); //remove when groups are fully tested.
 				// Group given.
-				$group = $this->validateName( $argv['group'] );
+				$group = $argv['group'];//don't apply validateName for group display
 				unset( $argv['group']);
 				--$cnt;
 			}
Comment 5 fdcn 2008-06-18 05:04:34 UTC
Created attachment 4996 [details]
update

update 

delete str_replace(' ','_',$)
Comment 6 Shinjiman 2008-06-18 18:43:27 UTC
Applied on r36431.
Comment 7 Brion Vibber 2008-06-19 20:42:04 UTC
Could you also add a parser test case for this to citeParserTests.txt?
Comment 8 fdcn 2008-06-20 02:50:05 UTC
Created attachment 5005 [details]
add parser test case for chinese groupname 

!! test
Simple <ref>, with <references/> in group, with groupname in chinese 
!! input
AAA<ref group="参">ref a</ref>BBB<ref group="注">note b</ref>CCC<ref group="参">ref c</ref>

;refs
<references group="参" />
;notes
<references group="注" />
!! result
<p>AAA<sup id="cite_ref-0" class="reference"><a href="#cite_note-0" title="">[参 1]</a></sup>BBB<sup id="cite_ref-1" class="reference"><a href="#cite_note-1" title="">[注 1]</a></sup>CCC<sup id="cite_ref-2" class="reference"><a href="#cite_note-2" title="">[参 2]</a></sup>

</p>
<dl><dt>refs
</dt></dl>
<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0" title="">↑</a> ref a</li>
<li id="cite_note-2"><a href="#cite_ref-2" title="">↑</a> ref c</li></ol>
<dl><dt>notes
</dt></dl>
<ol class="references"><li id="cite_note-1"><a href="#cite_ref-1" title="">↑</a> note b</li></ol>

!! end
Comment 9 Brion Vibber 2008-06-20 18:41:28 UTC
Thanks! Committed as r36513

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links