Last modified: 2010-05-15 15:54:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14212 - SkinSubPageSubtitle hook override is broken
SkinSubPageSubtitle hook override is broken
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2008-05-21 16:44 UTC by Edward Rudd
Modified: 2010-05-15 15:54 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Edward Rudd 2008-05-21 16:44:17 UTC
In 1.12.0 the subPagesubtitle hook does not work as expected if you return "false" to state "I overrode the implementation use my value"

here is a snip of the code starting from line 843 in file includes/Skin.php
      function subPageSubtitle() {
                $subpages = '';
                if(!wfRunHooks('SkinSubPageSubtitle', array(&$subpages)))
                        return $retval;

                global $wgOut, $wgTitle, $wgNamespacesWithSubpages;
                if($wgOut->isArticle() && !empty($wgNamespacesWithSubpages[$wgTitle->getNamespace()])) {

Note that if !wfRunHooks then $retval is returned, which is an undefined variable.

It *should* return $subpages.
Comment 1 Roan Kattouw 2008-05-21 20:07:37 UTC
Stupid mistake, I wrote a lot of "return $retval;" around that time. Fixed in r35145.

Note You need to log in before you can comment on or make changes to this bug.