Last modified: 2008-08-10 18:34:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14165 - LanguageXx.php files contain WMF specific settings
LanguageXx.php files contain WMF specific settings
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Language setup (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-17 17:24 UTC by Siebrand Mazeland
Modified: 2008-08-10 18:34 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
wgGrammarForms for 'gsw' (1.04 KB, patch)
2008-08-08 23:15 UTC, Siebrand Mazeland
Details
wgGrammarForms for 'ga' (437 bytes, patch)
2008-08-08 23:25 UTC, Siebrand Mazeland
Details
Cleanup for LanguageGa.php after wgGrammarForms for 'ga' (731 bytes, patch)
2008-08-08 23:26 UTC, Siebrand Mazeland
Details
wgGrammarForms for 'hu' (688 bytes, patch)
2008-08-08 23:34 UTC, Siebrand Mazeland
Details
Cleanup for LanguageHu.php after wgGrammarForms for 'hu' (1.03 KB, patch)
2008-08-08 23:34 UTC, Siebrand Mazeland
Details
wgGrammarForms for 'lv' (585 bytes, patch)
2008-08-08 23:49 UTC, Siebrand Mazeland
Details
Cleanup for LanguageLv.php after wgGrammarForms for 'lv' (1.31 KB, patch)
2008-08-08 23:49 UTC, Siebrand Mazeland
Details
wgGrammarForms for 'rmy' (1009 bytes, patch)
2008-08-09 00:00 UTC, Siebrand Mazeland
Details

Description Siebrand Mazeland 2008-05-17 17:24:09 UTC
13 LanguageXx.php files contain WMF specific settings that should be migrated to the Wikimedia configuration and taken out of the standard product. In all these cases, I am referring to conjugations of Wikimedia project names, that should end up in 'wgGrammarForms' in InitialiseSettings.php.

The following files contain settings that should be migrated to the local WMF configuration:
* LanguageBe.php
* LanguageBe_tarask.php
* LanguageBs.php
* LanguageCs.php
* LanguageDsb.php
* LanguageGa.php
* LanguageGsw.php
* LanguageHsb.php
* LanguageHu.php
* LanguageLv.php
* LanguageRmy.php
* LanguageSk.php
* LanguageSl.php
Comment 1 Danny B. 2008-05-27 14:31:30 UTC
LanguageCs.php solution in bug 14294.
Comment 2 Siebrand Mazeland 2008-08-08 20:33:23 UTC
* LanguageBe.php
* LanguageBe_tarask.php
* LanguageBs.php

Solution for the above also in bug 14294.
Comment 3 Siebrand Mazeland 2008-08-08 20:51:59 UTC
* LanguageDsb.php
* LanguageHsb.php

Solution for the above also in bug 14294.
Comment 4 Siebrand Mazeland 2008-08-08 23:15:25 UTC
Created attachment 5146 [details]
wgGrammarForms for 'gsw'

After configuring this, LanguageGsw.php can be deleted. There is no longer added functionality.
Comment 5 Siebrand Mazeland 2008-08-08 23:25:51 UTC
Created attachment 5147 [details]
wgGrammarForms for 'ga'
Comment 6 Siebrand Mazeland 2008-08-08 23:26:37 UTC
Created attachment 5148 [details]
Cleanup for LanguageGa.php after wgGrammarForms for 'ga'
Comment 7 Siebrand Mazeland 2008-08-08 23:34:20 UTC
Created attachment 5149 [details]
wgGrammarForms for 'hu'
Comment 8 Siebrand Mazeland 2008-08-08 23:34:35 UTC
Created attachment 5150 [details]
Cleanup for LanguageHu.php after wgGrammarForms for 'hu'
Comment 9 Siebrand Mazeland 2008-08-08 23:49:00 UTC
Created attachment 5151 [details]
wgGrammarForms for 'lv'
Comment 10 Siebrand Mazeland 2008-08-08 23:49:15 UTC
Created attachment 5152 [details]
Cleanup for LanguageLv.php after wgGrammarForms for 'lv'
Comment 11 Siebrand Mazeland 2008-08-09 00:00:47 UTC
Created attachment 5153 [details]
wgGrammarForms for 'rmy'

After configuring this, LanguageRmy.php can be deleted. There is no longer
added functionality.
Comment 12 Siebrand Mazeland 2008-08-09 13:52:55 UTC
Brion suggested a different, probably better solution, that is also much easier for Wikimedia shell operators: add all this stuff to the extension WikimediaMessages, and as a consequence, remove the section 'wgGrammarForms' from http://noc.wikimedia.org/conf/InitialiseSettings.php.html.

I have already made all necessary changes to files on my local system. Will discuss this on IRC when brion, Tim, or JeLuF is available. 
Comment 13 Siebrand Mazeland 2008-08-10 18:34:06 UTC
Fixed in r39077.

* (bug 14165, bug 14294) Wikimedia specific configuration in convertGrammar() for 13 localisations (be, be-tarask, bs, cs, dsb, ga, gsw, hsb, hu, lv, rmy, sk, sl) removed. The settings have been put in extension WikimediaMessages. For be, be-tarask, bs, dsb, hsb some duplicates (1=1) were removed. Patch for Czech by Danny B.
* Also put the wgGrammarForms from the Wikimedia configuration in here, so everything is in one place. Bonus with this setup is that there will be a little less work for Wikimedia shell operators, as the wgGrammarForms configuration is now accessible to i18n committers.
* Header for WikimediaMessages.php, and add myself to extension credits.

WARNING to Wikimedia shell operators: the whole section "wgGrammarForms" in InitialiseSettings.php.html should be remove after updating to this version. It will most probably overrule all settings in WikimediaMessages because of "'default' => array()"

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links