Last modified: 2010-05-15 16:03:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14147 - distinguish between local and shared repository dupes
distinguish between local and shared repository dupes
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.13.x
All All
: Normal minor (vote)
: ---
Assigned To: Bryan Tong Minh
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-16 09:04 UTC by Adrian Lang
Modified: 2010-05-15 16:03 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Adrian Lang 2008-05-16 09:04:03 UTC
The current dupelist links exclusively to the local project's file description page. This could lead to wrong links in a situation like the following:

* We are on Image:foo.jpg
* There is a dupe version at shared under Image:bar.jpg
* Local Image:bar.jpg differs from Image:foo.jpg

Same could happen the other way round:

* A user tags Image:bla.jpg as NowCommons under the name Image:bla2.jpg
* Local Image:bla2.jpg is a dupe of Image:bla.jpg
* Shared Image:bla2.jpg is a different file

Both problems massively limit the applicability of the dupe list.
Comment 1 Bryan Tong Minh 2008-05-16 09:08:41 UTC
Can you give me an example? I can't reproduce this; on my local wiki external links are used to distinguish between local and shared files.
Comment 2 Raimond Spekking 2008-05-16 09:11:54 UTC
Exa(In reply to comment #1)
> Can you give me an example? I can't reproduce this; on my local wiki external
> links are used to distinguish between local and shared files.
> 

One example from [[de:Category:NowCommons]]:

http://de.wikipedia.org/wiki/Bild:Albrecht-v-Preussen.JPG links to http://de.wikipedia.org/wiki/Bild:Albertvanpruisen.jpg but should link to http://commons.wikimedia.org/wiki/Image:Albertvanpruisen.jpg
Comment 3 Bryan Tong Minh 2008-05-16 09:27:11 UTC
For some reason a LocalFile is created instead of a LocalDBFile, but the repository is clearly still the shared repository.

Also note the bug that the namespace is translated.
Comment 4 Bryan Tong Minh 2008-05-16 20:51:47 UTC
I can't find the problem. It appears that ForeignDBRepo::newFileFromRow creates an LocalFile. There can be a few possibilities:
* ForeignDBRepo::findFilesBySha1 is directly inherited from LocalRepo, so it may call LocalRepo::newFileFromRow.
* ForeignDBFile::newFromRow creates a LocalFile instead of a ForeignDBFile.
Both do not occur to me on a local system, but maybe there is some version incompability between PHP or some caching problem?
Comment 5 Bryan Tong Minh 2008-05-30 09:58:50 UTC
Fixed by brion in r35576.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links