Last modified: 2010-12-14 17:15:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14128 - Readers without Javascript see box always in expanded state
Readers without Javascript see box always in expanded state
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 25389 (view as bug list)
Depends on:
Blocks: 26334
  Show dependency treegraph
 
Reported: 2008-05-14 21:11 UTC by P. Birken
Modified: 2010-12-14 17:15 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description P. Birken 2008-05-14 21:11:07 UTC
Readers without Jacascript see box always in expanded state which often overlaps some of the content. And well, there seems to be a surprising amount of people who have i) JS turned off and ii) are not willing to turn it on for WP.
Comment 1 Aaron Schulz 2008-05-14 21:28:32 UTC
The default is to show the data then. The reason it overlaps content is due to edits to MediaWiki:monobook.css, which is a local problem. It probably should be tweaked to use JS to set the class, IMO.
Comment 2 Melancholie 2008-05-15 01:16:37 UTC
See also: Bug 14035

@dewiki:

Maybe use some CSS like:
#mw-revisionratings {visibility:hidden}
#mw-revisionratings:hover {visibility:visible}

Or just hide at all that extended text for those non-JS twerps ;-)

Also try [maybe you need !important]:
#mw-revisiontag {width: ?px}
#mw-revisiontag:hover {width: ??px}
Comment 3 Melancholie 2008-05-15 01:21:56 UTC
@dewiki:
At least consider display:none for #mw-revisionratings-box, as the information of this box is pretty redundant!
Only for non-JS users, of course...
Comment 4 Melancholie 2008-05-15 01:25:36 UTC
Non-perfect CSS effects can be reversed by JS, by the way (if necessary).
Comment 5 entlinkt 2010-06-29 11:44:24 UTC
I disagree with the resolution of this bug. Comment 1 is wrong. Content is overlapped even without local adaptions. The local adaptions in [[de:MediaWiki:Monobook.css]] just try to minimize the amount of overlapped content by moving the whole box upwards. They don't affect other skins at all, Vector now being the default skin.

It would be trivial to achieve the collapse/expand effect without JavaScript. The Vector skin does this for the menu:

div.vectorMenu div.menu {
	display: none;
}
div.vectorMenu:hover div.menu {
	display: block;
}

If #mw-fr-revisiondetails were in a way related to #mw-fr-revisiontoggle that can be selected with CSS (e.g. descendant or later sibling, but not parent or earlier sibling), we could just do the same, like:

#mw-fr-revisiondetails {
	display: none; /* collapsed by default */
}
#mw-fr-revisiontoggle:hover #mw-fr-revisiondetails {
	display: block; /* expand if hovered */
}

This is impossible with the current document structure.

Note however that ...

* ... :hover does not work in IE 6. The JavaScript solution could be kept in place just for that browser;
* ... [[de:MediaWiki:Common.css]] currently contains some adaptions that affect all skins (z-index: 1 and display: none on #mw-fr-revisiondetails to stack it in the foreground of relatively positioned templates and hide it from non-JavaScript users). They are not the cause of this bug.
Comment 6 Aaron Schulz 2010-07-01 14:39:08 UTC
It used to push content down when expanded but was recently changed to use a flyout, so *now* it can overlap content.
Comment 7 Rob Lanphier (RobLa) 2010-07-12 21:30:26 UTC
Will change to display: none
Comment 8 Aaron Schulz 2010-07-14 19:03:07 UTC
(In reply to comment #7)
> Will change to display: none

To be clear, this means disabling the fly-out for non-JS browsing completely.
Comment 9 AlexSm 2010-08-09 15:00:20 UTC
Any progress on this? The issue was raised in my home wiki today. 

Meanwhile I'm thinking of adding this to Common.css:
div#mw-fr-revisiondetails {display:none}
Comment 10 Rob Lanphier 2010-11-29 22:30:37 UTC
Unassigning from Aaron, but this goes into the pool of issues that either Aaron or Priyanka will tackle (whoever has the time first).  This bug is duplicated by bug 25389, which I'll be closing and pointing here.
Comment 11 Rob Lanphier 2010-11-29 22:31:06 UTC
*** Bug 25389 has been marked as a duplicate of this bug. ***
Comment 12 Aaron Schulz 2010-11-30 21:01:51 UTC
Done in r77510.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links