Last modified: 2008-05-12 20:27:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14089 - spam blacklist manual seems to be obsolete/wrong
spam blacklist manual seems to be obsolete/wrong
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Spam Blacklist (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.mediawiki.org/wiki/Extensi...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-12 09:11 UTC by seth
Modified: 2008-05-12 20:27 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description seth 2008-05-12 09:11:16 UTC
There are some minor inconsistencies between manual and source-code.

1. The script does a preparsing which greps all external urls and separates them by "\n".
For the regexp-s-modifier is not used, it wouldn't be necessary to avoid patterns like ".*" as it is said in the manual. ".*" would only match until EOL, wouldn't it?

2. Actually the code !http://[a-z0-9\-.]*(line 1|line 2|...)!Si in manual is not the right one, because "!" is not the delimiter character used in the script. (So escaping like \! wouldn't be necessary to match a "!".)

3. The header of those blacklists always say "Every non-blank line is a regex fragment which will only match hosts inside URLs", while that isn't true. It does not only match hosts, it matches the path, too.
Comment 1 Brion Vibber 2008-05-12 18:33:03 UTC
The page is not protected -- do feel free to fix it directly rather than waiting for someone else! :)
Comment 2 seth 2008-05-12 20:27:50 UTC
ok, i fixed the first two bugs.
but i guess i can't fix the third one. it problably has nothing to do with the extension itself but is a mistake of the spamlist-users. so i'll mark this whole bug as fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links