Last modified: 2008-05-13 18:59:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16063, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 14063 - Power search form missing <label> for redirects check
Power search form missing <label> for redirects check
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Search (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Special:...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-05-09 20:31 UTC by Brion Vibber
Modified: 2008-05-13 18:59 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2008-05-09 20:31:22 UTC 
The power search form on [[Special:Search]] has a "List redirects" checkbox, which has no attached <label> on its label text. This means clicking the label doesn't activate the checkbox, unlike the giant pile of namespace checkboxes right next to it.

This is due to [[MediaWiki:Powersearchtext]] being godawful and tossing label text in the middle of layout and such.
Comment 1 Huji 2008-05-11 17:09:31 UTC 
The solution is straightforward: "List redirects" should be moved to a new message, then used inside [[MediaWiki:Powersearchtext]] (as a parameter). Then the lable can be added easily from inside SpecialSearch.php so, except for the moving, the rest takes only a minute.

I'm CCing Siebrand, because I think he is the best person who can deal with the message moving part.
Comment 2 Siebrand Mazeland 2008-05-11 19:06:47 UTC 
Not going to mess with code. If someone fixes it, I'll take care of moving messages around for localisations...
Comment 3 Huji 2008-05-12 14:28:47 UTC 
I fixed the code and MessagesEn.php by r34661. The localization part is waiting for you :) I'm marking the bug as fixed.
Comment 4 Brion Vibber 2008-05-13 18:59:44 UTC 
Further cleanup in r34751 -- layout and localization are now cleanly separated.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links