Last modified: 2010-05-15 16:03:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14042 - Comments in wrong spot in SQL logs
Comments in wrong spot in SQL logs
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.13.x
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
http://svn.wikimedia.org/viewvc/media...
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-08 13:12 UTC by Christian Neubauer
Modified: 2010-05-15 16:03 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christian Neubauer 2008-05-08 13:12:27 UTC
The function Database->limitResult adds a blank space to the beginning of SQL queries for some reason.  When logging SQL, this space causes comments to be added to the beginning of the SQL instead of after the command in Database->query.

Expected result in log:
SQL: SELECT /* SiteStatsUpdate::doUpdate UserName */  *  FROM `site_stats`   LIMIT 1

Actual Result in log:
SQL : /* SiteStatsUpdate::doUpdate UserName */ SELECT  *  FROM `site_stats`   LIMIT 1
Comment 1 Christian Neubauer 2008-05-08 15:47:03 UTC
By the way, this can be fixed by deleting the extra space in front of the $sql variable in Database->limitResult.  About as easy as they come.
Comment 2 Roan Kattouw 2008-05-08 15:51:20 UTC
Fixed in r34441

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links