Last modified: 2010-12-22 21:27:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16020, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 14020 - API for Special:Unwatchedpages
API for Special:Unwatchedpages
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.13.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on: 14869
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-07 19:53 UTC by Roan Kattouw
Modified: 2010-12-22 21:27 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Starting point for implementation (2.14 KB, patch)
2008-07-16 13:22 UTC, Chad H.
Details

Description Roan Kattouw 2008-05-07 19:53:20 UTC
The API should be able to list unwatched pages. The best way is probably to implement this as a parameter of list=allpages (apfilterwatched). In SQL, this should probably be done as a LEFT JOIN against the watchlist table, then looking for wl_title IS (NOT) NULL. We also might wanna add an option to disable this for large wikis (Special:Unwatchedpages is cached at enwiki), after discussing with people who know why it's cached.
Comment 1 Chad H. 2008-07-16 13:22:35 UTC
Created attachment 5075 [details]
Starting point for implementation

Doesn't quite work yet, but I'm unfamiliar with the API's code. Copied the filter-by-langlinks bit as a base for implementation.
Comment 2 Roan Kattouw 2008-07-16 15:48:05 UTC
Committed a modified version of that patch in r37748. In case you're interested, I changed the following things:

* The USE INDEX had to be adjusted to avoid SQL errors
* Removed the page_is_redirect=0 and page_namespace <> NS_MEDIAWIKI conditions, as it's up to the client whether they even *want* all that (the apfilterredir and apnamespace parameters)
* Moved the addTables() and addJoinConds() calls to a more generic place so they aren't duplicated
* Used arrays instead of WHERE clauses with AND in them
* Set a warning if $wgMiserMode is true or if the user doesn't have the 'unwatchedpages' right
* Moved the global $wgUser, $wgMiserMode; statement down to where it's actually used
Comment 3 MER-C 2008-11-06 04:35:05 UTC
Reverted in r37775.
Comment 4 Roan Kattouw 2008-11-06 13:38:55 UTC
This'll be automatically fixed once someone fixes bug 14869.
Comment 5 Sam Reed (reedy) 2010-03-06 18:08:31 UTC
Closing as "resolved/later"

Will be fixed by bug 14869, and makes the API bug list a bit clearer (as these are essentially duplicates)
Comment 6 Roan Kattouw 2010-12-22 21:27:15 UTC
(In reply to comment #5)
> Closing as "resolved/later"
> 
> Will be fixed by bug 14869, and makes the API bug list a bit clearer (as these
> are essentially duplicates)
Done now (branch merged in r78786).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links