Last modified: 2011-11-09 23:17:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13956 - In Atom/RSS feeds a changed content sometimes is not displayed red
In Atom/RSS feeds a changed content sometimes is not displayed red
Status: NEW
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
unspecified
All All
: Low minor with 4 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://de.wikibooks.org/w/index.php?t...
:
Depends on:
Blocks: feeds
  Show dependency treegraph
 
Reported: 2008-05-05 10:45 UTC by Melancholie
Modified: 2011-11-09 23:17 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Melancholie 2008-05-05 10:45:27 UTC
News feed readers and Mozilla Thunderbird e.g. do show a colored revision comparison for Atom/RSS feeds.

But sometimes changed words/content is not shown red, see

1. http://de.wikibooks.org/w/index.php?title=Esperanto&diff=374797&oldid=364671 (where it's red)
2. http://de.wikibooks.org/w/index.php?title=Esperanto&feed=rss&action=history (where no red color is used)
3. http://de.wikibooks.org/w/index.php?title=Linux-Kompendium&feed=rss&action=history (where style code is marking words red)

So, sometimes style="color: red; font-weight: bold; text-decoration: none;" is missing; instead class="diffchange diffchange-inline" is used, but does not work (at least for Thunderbird). This occurs for RSS and Atom.
Comment 1 Brion Vibber 2008-05-07 02:14:17 UTC
The styles are applied by hardcoding to the feed output by rcApplyDiffStyle() in SpecialRecentchanges.php.

This function is a bit of a hack, and doesn't properly handle multiple classes (eg class="diffchange diffchange-inline"), which are now produced due to recent changes to the diff engine. (But not _always_ produced on Wikipedia, since we currently have a mix of wikidiff2 versions installed.)

The function should be updated to handle multiple classes, either with another hack or by rewriting it to use proper DOM functions or such.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links