Last modified: 2008-09-18 21:01:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13930 - Support for rev_deleted in sql dumps
Support for rev_deleted in sql dumps
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-02 18:23 UTC by Bryan Tong Minh
Modified: 2008-09-18 21:01 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for rev_deleted (2.63 KB, patch)
2008-05-02 18:23 UTC, Bryan Tong Minh
Details
Patch that actually outputs correct shell commands (2.74 KB, patch)
2008-05-02 18:26 UTC, Bryan Tong Minh
Details

Description Bryan Tong Minh 2008-05-02 18:23:15 UTC
Created attachment 4871 [details]
Patch for rev_deleted

Attached patch for the backup system to support the rev_deleted system.
Comment 1 Bryan Tong Minh 2008-05-02 18:26:14 UTC
Created attachment 4872 [details]
Patch that actually outputs correct shell commands
Comment 2 Brion Vibber 2008-05-02 20:14:34 UTC
This doesn't really look suitable; entire records are being suppressed instead of the individual hidden fields.

For instance, we shouldn't drop an entire revision's metadata just because the comment was suppressed (which should blank only one field) or the text (which would not even be included in the output!)

Further, giving the same filename to dumps which contain different data looks unwise.
Comment 3 Bryan Tong Minh 2008-05-02 20:18:28 UTC
(In reply to comment #2)
> This doesn't really look suitable; entire records are being suppressed instead
> of the individual hidden fields.
> 
> For instance, we shouldn't drop an entire revision's metadata just because the
> comment was suppressed (which should blank only one field) or the text (which
> would not even be included in the output!)
> 
Well in that case we probably have to make our own version of mysqldump. I don't see how to do it otherwise.

> Further, giving the same filename to dumps which contain different data looks
> unwise.
> 
Are you referring to the fact that the public and private versions of tables have the same name? But they go into different directories, right?
Comment 4 Brion Vibber 2008-05-02 20:20:27 UTC
There's not a pressing need to do a public dump of the revision table these days, as the XML stub dumps contain that data.

Something nice for the logging table might be needed.

They go in the same directory for private wikis. Even if they didn't, having the identical name for *opposite data* is very bad and will be extremely confusing to anyone having to work with or preserve those files.
Comment 5 Brion Vibber 2008-05-02 21:40:51 UTC
They do not go in different directories for private wikis.
Comment 6 Siebrand Mazeland 2008-08-18 13:03:08 UTC
Bryan, any progress?
Comment 7 Aaron Schulz 2008-09-17 18:22:23 UTC
So we need an xml log dump then?
Comment 8 Aaron Schulz 2008-09-18 21:01:55 UTC
Done in r40968

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links