Last modified: 2011-07-09 01:49:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13928 - SpecialUpload warning results in long buttons
SpecialUpload warning results in long buttons
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Raimond Spekking
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-02 13:27 UTC by Carl Fürstenberg
Modified: 2011-07-09 01:49 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot if a long button on commons, sadly my screen isn't wide enough to see the whole button (227.74 KB, image/png)
2008-05-02 13:27 UTC, Carl Fürstenberg
Details

Description Carl Fürstenberg 2008-05-02 13:27:47 UTC
Created attachment 4870 [details]
screenshot if a long button on commons, sadly my screen isn't wide enough to see the whole button

Per r32493 the button on commons for save file on warning gets really long, see attachment.
Comment 1 Huji 2008-05-02 16:42:50 UTC
The original MediaWiki messages is "ignore warning and save file anyway". It doesn't generate a large button. The problem happens because http://commons.wikimedia.org/wiki/MediaWiki:Ignorewarning is changed from the original message. The person who changed it didn't notice that '''bolding text''' doesn't have an effect on buttons, and didn't pay attention that he is generating large buttons.

All in all, this is not a bug in MediaWiki, and should be fixed on Commons. If there is a real need to show that warning to users, another message can be added (by a separate request on Bugzilla, for example) about it.
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-05-02 16:59:56 UTC
Disagree, the changes introduced by r32493 were almost certainly mistakes.  The 'ignorewarning' and 'reuploaddesc' messages formerly accepted wikitext and now do not, with no explanation given, and the 'savefile' and 'reupload' messages are now no longer used, but they were not removed from the message list.  The latter two are supposed to be the labels for the buttons, the former two are supposed to be descriptions.  I would revert this, but there are conflicts.
Comment 3 Raimond Spekking 2008-05-02 17:13:33 UTC
(In reply to comment #2)
> Disagree, the changes introduced by r32493 were almost certainly mistakes.  The
> 'ignorewarning' and 'reuploaddesc' messages formerly accepted wikitext and now
> do not, with no explanation given, and the 'savefile' and 'reupload' messages
> are now no longer used, but they were not removed from the message list.  The
> latter two are supposed to be the labels for the buttons, the former two are
> supposed to be descriptions.  I would revert this, but there are conflicts.
> 

My intention was to simplify the form a bit and kill the ugly table construction. But I missed to remove the two now unused messages and the usage of wikitext in buttons.
Comment 4 Siebrand Mazeland 2008-08-18 13:13:55 UTC
Assigned: Raimond. To either mark resolved, or to fix and mark resolved after
that :)
Comment 5 Guillaume Paumier 2009-12-31 02:28:18 UTC
Raimond, what's the status of this bug please?
Comment 6 Dan Collins 2011-07-09 01:49:49 UTC
This bug as written is not a MediaWiki bug, the issue was with common localization, and it was fixed years ago. There seems to be some residual question regarding whether those messages should exist or accept wikitext, but since the person who made the change hasn't commented in three years and no one else seems particularly broken up, I'm marking invalid.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links