Last modified: 2010-05-15 16:03:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T15916, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 13916 - $wgShowUpdatedMarker requirement for $wgEnotifWatchlist is inconsistent and undocumented


Summary:	$wgShowUpdatedMarker requirement for $wgEnotifWatchlist is inconsistent and u...

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.13.x
Hardware:	All All

Importance:	Normal normal with 1 vote (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-05-01 15:44 UTC by Jelte (WebBoy)
Modified:	2010-05-15 16:03 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch 1: Consistently require $wgEnotifWatchlist to be true (3.60 KB, patch) 2008-05-01 15:44 UTC, Jelte (WebBoy)	Details
Patch 2: Completely remove the $wgEnotifWatchlist requirement (1.61 KB, patch) 2008-05-01 15:46 UTC, Jelte (WebBoy)	Details
Updated patch (1.09 KB, patch) 2008-05-20 20:35 UTC, Jelte (WebBoy)	Details
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Description Jelte (WebBoy) 2008-05-01 15:44:04 UTC

Created attachment 4863 [details]
Patch 1: Consistently require $wgEnotifWatchlist to be true

Currently, $wgShowUpdatedMarker requires $wgEnotifWatchlist to be true to function correctly. But this requirement is not documented and not consistently programmed.

Besides extra database queries this is causing a bug:

When you first enable and then disable $wgEnotifUserTalk and $wgEnotifWatchlist and leave $wgShowUpdatedMarker unchanged (default: true) any left over "updated since my last visit" marks won't go away.

There are two solutions:
1: Consistently require $wgEnotifWatchlist to be true, see patch 1.
2: Completely remove the $wgEnotifWatchlist requirement, see patch 2.

I'd prefer solution 2 because it's more flexible.

Comment 1 Jelte (WebBoy) 2008-05-01 15:46:43 UTC

Created attachment 4864 [details]
Patch 2: Completely remove the $wgEnotifWatchlist requirement

Note: when applying this patch, $wgShowUpdatedMarker should probably be set to false (default: true) on large wikis.

Comment 2 Jelte (WebBoy) 2008-05-20 20:35:39 UTC

Created attachment 4908 [details]
Updated patch

Partly fixed by r35002 (solution 2).

Attached updated patch.

Comment 3 Aaron Schulz 2008-05-21 05:13:20 UTC

Done in r35112

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links