Last modified: 2010-05-15 16:03:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13916 - $wgShowUpdatedMarker requirement for $wgEnotifWatchlist is inconsistent and undocumented
$wgShowUpdatedMarker requirement for $wgEnotifWatchlist is inconsistent and u...
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
  Show dependency treegraph
Reported: 2008-05-01 15:44 UTC by Jelte (WebBoy)
Modified: 2010-05-15 16:03 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Patch 1: Consistently require $wgEnotifWatchlist to be true (3.60 KB, patch)
2008-05-01 15:44 UTC, Jelte (WebBoy)
Patch 2: Completely remove the $wgEnotifWatchlist requirement (1.61 KB, patch)
2008-05-01 15:46 UTC, Jelte (WebBoy)
Updated patch (1.09 KB, patch)
2008-05-20 20:35 UTC, Jelte (WebBoy)

Description Jelte (WebBoy) 2008-05-01 15:44:04 UTC
Created attachment 4863 [details]
Patch 1: Consistently require $wgEnotifWatchlist to be true

Currently, $wgShowUpdatedMarker requires $wgEnotifWatchlist to be true to function correctly. But this requirement is not documented and not consistently programmed.

Besides extra database queries this is causing a bug:

When you first enable and then disable $wgEnotifUserTalk and $wgEnotifWatchlist and leave $wgShowUpdatedMarker unchanged (default: true) any left over "updated since my last visit" marks won't go away.

There are two solutions:
1: Consistently require $wgEnotifWatchlist to be true, see patch 1.
2: Completely remove the $wgEnotifWatchlist requirement, see patch 2.

I'd prefer solution 2 because it's more flexible.
Comment 1 Jelte (WebBoy) 2008-05-01 15:46:43 UTC
Created attachment 4864 [details]
Patch 2: Completely remove the $wgEnotifWatchlist requirement

Note: when applying this patch, $wgShowUpdatedMarker should probably be set to false (default: true) on large wikis.
Comment 2 Jelte (WebBoy) 2008-05-20 20:35:39 UTC
Created attachment 4908 [details]
Updated patch

Partly fixed by r35002 (solution 2).

Attached updated patch.
Comment 3 Aaron Schulz 2008-05-21 05:13:20 UTC
Done in r35112

Note You need to log in before you can comment on or make changes to this bug.