Last modified: 2010-05-15 16:03:55 UTC
Created attachment 4863 [details]
Patch 1: Consistently require $wgEnotifWatchlist to be true
Currently, $wgShowUpdatedMarker requires $wgEnotifWatchlist to be true to function correctly. But this requirement is not documented and not consistently programmed.
Besides extra database queries this is causing a bug:
When you first enable and then disable $wgEnotifUserTalk and $wgEnotifWatchlist and leave $wgShowUpdatedMarker unchanged (default: true) any left over "updated since my last visit" marks won't go away.
There are two solutions:
1: Consistently require $wgEnotifWatchlist to be true, see patch 1.
2: Completely remove the $wgEnotifWatchlist requirement, see patch 2.
I'd prefer solution 2 because it's more flexible.
Created attachment 4864 [details]
Patch 2: Completely remove the $wgEnotifWatchlist requirement
Note: when applying this patch, $wgShowUpdatedMarker should probably be set to false (default: true) on large wikis.
Created attachment 4908 [details]
Partly fixed by r35002 (solution 2).
Attached updated patch.
Done in r35112