Last modified: 2008-05-01 20:27:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13905 - Wikipedia not accepting login
Wikipedia not accepting login
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
Macintosh All
: Normal blocker (vote)
: ---
Assigned To: Brion Vibber
Depends on:
  Show dependency treegraph
Reported: 2008-05-01 03:56 UTC by Franny Wentzel
Modified: 2008-05-01 20:27 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Franny Wentzel 2008-05-01 03:56:21 UTC
Not accepting logins. Claims my browser (MSIE5 for Mac) is not accepting cookies even when set to 'never ask'.
Comment 1 Brion Vibber 2008-05-01 17:55:58 UTC
Confirmed with IE 5.2.3 (5815.1) on Mac OS X 10.5.2.

Might be related to the recent use of HttpOnly cookies; however my standalone cookie test page appears to be working fine. Will investigate, see if there's some extra interaction that's breaking things.
Comment 2 Brion Vibber 2008-05-01 20:27:08 UTC
Fixed in r34083... (note the fix is not live yet but will be shortly)

The particular situation was that the session cookie was getting eaten as "disabled", thus not sent back to the server so your session state never quite happened. Other cookies on submit seemed to come in intact, but without the session cookie you'd get a big fat error message, even if you set the long-term login cookie option.

Mac/IE seems to always *see* the HttpOnly cookies, but it sometimes marks them as "disabled". It seems to be incorrectly parsing the options after the path, sometimes seeing "/;" as the path instead of "/". Failure is more likely if there's no expiration option (as with the session cookie), or if there *is* a secure option set.

Anyway, just set up a user-agent blacklist $wgHttpOnlyBlacklist and copied the Mac/IE entry over. The HttpOnly setting now gets ignored for blacklist hits as well as for old PHP versions, the check being encapsulated into wfHttpOnlySafe().

Also added some logging for cookie settings, around the setcookie() and session_set_cookie_params() calls.

Note You need to log in before you can comment on or make changes to this bug.