Last modified: 2008-05-02 08:59:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13900 - add video/ogg and application/annodex to mimetypes
add video/ogg and application/annodex to mimetypes
Product: MediaWiki extensions
Classification: Unclassified
OggHandler (Other open bugs)
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
  Show dependency treegraph
Reported: 2008-04-30 17:51 UTC by Jan Gerber
Modified: 2008-05-02 08:59 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

the patch (584 bytes, patch)
2008-04-30 19:13 UTC, Jan Gerber

Description Jan Gerber 2008-04-30 17:51:53 UTC
right now cortado only check for application/ogg and fails for ogg/video or application/annodex, it should also try to decode those.
attached a patch to check for those mime-types too.
Comment 1 Brion Vibber 2008-04-30 18:58:03 UTC
Attachment doesn't seem to have made it.
Comment 2 Jan Gerber 2008-04-30 19:13:11 UTC
Created attachment 4853 [details]
the patch
Comment 3 Brion Vibber 2008-05-01 17:48:40 UTC
If we're to believe we should probably toss in audio/ogg as well.

Comments in Cortado source seem to indicate that annodex streams aren't really supported properly as well, so perhaps we should *not* add those types?
Comment 4 Tim Starling 2008-05-02 01:24:12 UTC
What's the point of this?
Comment 5 Tim Starling 2008-05-02 02:01:00 UTC
I'll make myself a bit more clear: the MIME type should always come from OggDemux.getMime(), and is always application/ogg. It doesn't come from the webserver. If OggDemux.typeFind() is not recognising the header, then maybe it will then try to use the content type from the webserver, and give you a confusing error about type mismatch. Is this the problem? If so, the bug  is the error handling, not the MIME type list. If the signature is invalid, it should tell you so, and refuse to play the file.
Comment 6 Jan Gerber 2008-05-02 08:59:35 UTC
indeed, i got an error message video/ogg not supported than changed that in the source and it worked,
removing it again now it also works so the error must have been something else.

Note You need to log in before you can comment on or make changes to this bug.