Last modified: 2012-01-10 19:11:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13884 - Better validation for Type:URL and Type:Email
Better validation for Type:URL and Type:Email
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Markus Krötzsch
http://sandbox.semantic-mediawiki.org...
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-29 23:59 UTC by S Page
Modified: 2012-01-10 19:11 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch from Asheesh Laroia (632 bytes, patch)
2008-04-29 23:59 UTC, S Page
Details

Description S Page 2008-04-29 23:59:28 UTC
Created attachment 4850 [details]
patch from Asheesh Laroia

On [SMW-devel] [PATCH] SMW rejects .info as email address, Asheesh Laroia comments :

  Right now, includes/SMW_DV_URI.php has, in its regex for case SMW_URI_MODE_EMAIL , a check that only allows domains of length between 2 and 3 (inclusive).

  This breaks .info addresses.

User's patch still won't allow new e-mail addresses in new .travel, and .museum domains, see http://en.wikipedia.org/wiki/Generic_top-level_domain

There's a long discussion of e-mail validation at 
http://www.regular-expressions.info/email.html ,
SMW_DV_URI.php should probably copy one of those regexps and use it with a comment referring to the discussion.
Comment 1 Markus Krötzsch 2008-04-30 08:33:47 UTC
OK, I modified the code as suggested and extended the possible characters to up to 6 (this includes museum). Better regexps should be used at some latter stage (also for URLs), and I modify this bug report accordingly.
Comment 2 Sumana Harihareswara 2011-12-23 18:17:22 UTC
(In reply to comment #1)
> OK, I modified the code as suggested and extended the possible characters to up
> to 6 (this includes museum).

Am therefore marking patch as reviewed.
Comment 3 badon 2012-01-10 05:00:33 UTC
This appears to have been resolved as FIXED. I changed the status accordingly. Please reopen if that is incorrect.
Comment 4 Sumana Harihareswara 2012-01-10 13:01:17 UTC
badon -- if the problem has been fixed and you know what revision number it has been fixed in, you should link to it with r#### in a comment here on Bugzilla.  If you simply believe the problem is fixed because you can no longer reproduce the issue, please instead resolve as WORKSFORME.
Comment 5 badon 2012-01-10 19:11:42 UTC
Will do, thanks for the advice.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links