Last modified: 2008-04-30 18:30:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13880 - Printable version link not properly formatted with Modern skin
Printable version link not properly formatted with Modern skin
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/BAE_Syst...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-29 20:56 UTC by Brion Vibber
Modified: 2008-04-30 18:30 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
proposed patch (445 bytes, patch)
2008-04-30 13:46 UTC, Alexandre Emsenhuber [IAlex]
Details

Description Brion Vibber 2008-04-29 20:56:05 UTC
The "printable version" link (adding printable=yes to the query string) is meant to activate the print stylesheet for on-screen display.

On the Modern skin, this isn't working correctly. While many UI elements correctly disappear, the background, borders, sidebar, fonts etc are still all there as the on-screen display.

An actual print preview shows a nice spare "print look", which may indicate that this skin is using its own @media print overrides.

(Tested in Firefox 3.0b5)
Comment 1 Alexandre Emsenhuber [IAlex] 2008-04-30 13:46:17 UTC
Created attachment 4851 [details]
proposed patch

patch to add new rules in print.css, tested in Minefield (i.e. Firefox) 3.0b5 and Firefox 2.0.0.7.

Maybe modern skin should also load skins/common/commonPrint.css like monobook does.
Comment 2 Brion Vibber 2008-04-30 18:30:32 UTC
Aha! Figured it out and fixed in r34058.

Problem was that the Modern skin uses a different way of setting up the print stylesheet from the other skins.

Others:
* always include main stylesheet
* override that stuff with print stylesheet for print media or ?printable=yes

Modern:
* include main stylesheet for screen & projection media only
* add some additional print styles for print media or ?printable=yes

The screen stylesheet was still being used when ?printable=yes is set, but would be hidden when actually printing. I've changed it to now exclude the screen stylesheets when ?printable=yes is switched in, so it looks the same on screen as when actually printing.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links