Last modified: 2011-05-15 10:08:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13879 - Special:Emailuser should have an input form
Special:Emailuser should have an input form
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal enhancement with 3 votes (vote)
: ---
Assigned To: Purodha Blissenbach
:
: 19679 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-29 18:52 UTC by Church of emacs
Modified: 2011-05-15 10:08 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch against head, implements a "specify user" form (1.93 KB, patch)
2008-05-10 04:49 UTC, Chad H.
Details

Description Church of emacs 2008-04-29 18:52:18 UTC
If you enter [[Special:Emailuser]] without specifying the target user, you get the following error message:

"You have not specified a target page or user on which to perform this function."

It'd be great to have an input mask instead, where you can just enter the user name and get the page Special:Emailuser/username (or Special:Emailuser?target=username).
I think, this is also how it's done in Special:Contributions
Comment 1 Brion Vibber 2008-04-29 21:36:35 UTC
Clarified summary.
Comment 2 Chad H. 2008-05-10 04:49:35 UTC
Created attachment 4891 [details]
Patch against head, implements a "specify user" form

This patch will implement a "Specify user" form if there is no target user.
Comment 3 Chad H. 2008-05-12 13:47:04 UTC
Comment on attachment 4891 [details]
Patch against head, implements a "specify user" form

Bad patch against current trunk with EmailUser refactor. Looking at rewriting this patch again and better implementing it.
Comment 4 Bryan Tong Minh 2008-05-12 14:48:53 UTC
I suggest that we just make the "To" field an input box and show the full form when errors occur.
Comment 5 Siebrand Mazeland 2008-08-18 13:54:45 UTC
Assigned: demon (who probably just forgot he commented here)
Comment 6 Bryan Tong Minh 2008-08-21 22:15:59 UTC
Fixed in r39793.
Comment 7 Chad H. 2008-08-22 01:38:44 UTC
Reverted by Brion in r39799
Comment 8 Brion Vibber 2008-12-12 23:03:17 UTC
Bumping with comments from the revert:

* (bug 13879) Special:EmailUser shows a form in case no user was specified" for the moment
* Recipient name seems to be output raw into HTML form; this is insecure
* We've lost the link to the target's user page in the primary use case (followed 'email this user' link)
* Behavior if you misspell a name doesn't look very nice; you can't just fix it and resubmit the form, you have to hit 'back' from an error page and hope your browser isn't one that deletes all your form data :D
Comment 9 Alexandre Emsenhuber [IAlex] 2009-07-12 21:09:07 UTC
*** Bug 19679 has been marked as a duplicate of this bug. ***
Comment 10 Umherirrender 2010-06-10 18:54:56 UTC
Maybe WONTFIX, per bug 13349 comment 3?
Comment 11 Platonides 2010-06-10 20:12:03 UTC
bug 13349 comment 3 means that Emailuser shouldn't bve listed there until it gets an input form, which is quite different than "it can't have an input form".
Comment 12 Umherirrender 2010-06-11 19:12:27 UTC
Special:MovePage can also have a input form, but he does not, because the page is "task-oriented, to be reached directly from their tasks", the same for Emailuser. The task "send email" is started when click the link on the userpage.
Comment 13 Church of emacs 2010-06-11 19:41:19 UTC
In the meantime, I changed my mind and now I agree with Umherirrender. There are lots of special pages that require parameters and don't have an input form. If they're unlisted (i.e. not in Special:Specialpages), that's okay.
Comment 14 MZMcBride 2010-06-11 19:57:17 UTC
(In reply to comment #13)
> In the meantime, I changed my mind and now I agree with Umherirrender. There
> are lots of special pages that require parameters and don't have an input form.
> If they're unlisted (i.e. not in Special:Specialpages), that's okay.

This seems like a reason to fix the other forms, not keep them as they are.
Comment 15 Church of emacs 2010-06-11 20:04:26 UTC
And why should a page like Special:RevisionDelete have a form? They have an input form, it's just not on the special page itself, but somewhere it belongs (in case of RevisionDelete, it's in the page history and diffs).
Comment 16 Chad H. 2010-06-11 22:06:46 UTC
(In reply to comment #14)
> (In reply to comment #13)
> > In the meantime, I changed my mind and now I agree with Umherirrender. There
> > are lots of special pages that require parameters and don't have an input form.
> > If they're unlisted (i.e. not in Special:Specialpages), that's okay.
> 
> This seems like a reason to fix the other forms, not keep them as they are.

+1. REOPENING.
Comment 17 Purodha Blissenbach 2011-04-12 13:22:17 UTC
Fixed in r85876 and r85877.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links