Last modified: 2008-04-22 22:36:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13824 - Suggestion search drop-down with skin "modern"
Suggestion search drop-down with skin "modern"
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Brion Vibber
http://nl.wikipedia.org
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-22 20:51 UTC by Peter van Londen
Modified: 2008-04-22 22:36 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Peter van Londen 2008-04-22 20:51:10 UTC
Great tool, but I like working with the new skin modern. The suggestion search dropdown/OpenSearch does not seem to work with this skin modern, whereas it works well with the Monobook skin.
Comment 1 Brion Vibber 2008-04-22 22:36:10 UTC
Fixed in r33759.

The setup code was using a MonoBook-specific div ID to insert the results container into. Swapped that for the plain ol' document.body and fixed the styles for MonoBook and Modern so it gets the scale-up fix for the font size (they both use a weird system where they shrink the font size on the body, then scale it back up inside.... very wtf territory!)

Added setup for form and input IDs used for the second search box on Cologne Blue, and copied those IDs over to Nostalgia and Classic skins.

Note that the drop-down is a bit unsatisfactory on the page-bottom search boxes in Nostalgia, Classic, and Cologne Blue, as it tries to squish in at the bottom of the page, and you only get two lines of data. The sidebar search boxes are also not very wide, which makes results pretty cramped.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links