Last modified: 2010-05-15 16:03:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13815 - Add a nbsp before colon in the comment of page move
Add a nbsp before colon in the comment of page move
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.13.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Aryeh Gregor (not reading bugmail, please e-mail directly)
http://fr.wikipedia.org/w/index.php?t...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-21 21:25 UTC by Seb35
Modified: 2010-05-15 16:03 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Seb35 2008-04-21 21:25:37 UTC
In view of bug 11810 and bug 13273, is it possible to localize the colon in the comment of a page move (see url).

The change should be in the class Title, function moveToNewTitle, at the beginning of the function.

Thank you
Comment 1 Seb35 2008-07-14 13:22:51 UTC
I've tried to resolve this bug, but when I introduce wfMsgExt( 'colon-separator', array( 'escapenoentities', 'content' ) ) all   and   are displayed inline in the comment. I haven't found the good options to replace the nbsp by a true non-breaking space, it is a sort of reverse parsing (nbsp to inline) and I don't know if it exist a such parsing method.

There is some other occurrences where it would be better to use the colon-separator message (I founded two in the file Article.php), perhaps we could open a tracking bug.

Simetrical, I added you to the CC list because you propose it in the bug 13273.
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-07-14 13:43:07 UTC
What was your patch that didn't work?  What exactly was wrong with it?  What does "displayed inline in the comment" mean?
Comment 3 Seb35 2008-07-14 15:59:28 UTC
Yes, sorry. My patch is

Index: includes/Title.php
===================================================================
--- includes/Title.php	(révision 37636)
+++ includes/Title.php	(copie de travail)
@@ -2718,7 +2718,7 @@
 		$fname = 'MovePageForm::moveToNewTitle';
 		$comment = wfMsgForContent( '1movedto2', $this->getPrefixedText(), $nt->getPrefixedText() );
 		if ( $reason ) {
-			$comment .= ": $reason";
+			$comment .= wfMsgExt( 'colon-separator', array( 'escapenoentities', 'content' ) ) . $reason;
 		}
 
 		$newid = $nt->getArticleID();

I have used the same function as you in r31805, but the result in the history is
 (actu) (diff)  14 juillet 2008 à 10:34 Seb35 (Discuter | Contributions | Bloquer) m (a renommé Accueil en Accueillit : essai3) (défaire)
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-07-14 21:44:18 UTC
Fixed in r37663.  It was being escaped a second time in Linker::formatComment; that needed to be fixed as well.
Comment 5 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-07-15 22:50:25 UTC
This was reverted in r37714.  I'm waiting for the okay to recommit it.
Comment 6 Siebrand Mazeland 2008-08-18 17:07:02 UTC
Assigned: Simetrical. May be easy to overlook the waiting part if this issue is not assigned.
Comment 7 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-08-18 18:16:17 UTC
Re-committed in r39600, which is *not* right before a release.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links