Last modified: 2010-05-15 15:59:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13788 - getThumbnails broken when not running isHashed
getThumbnails broken when not running isHashed
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.11.x
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-18 21:36 UTC by Jon Boede
Modified: 2010-05-15 15:59 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon Boede 2008-04-18 21:36:18 UTC
The getThumbnails function (LocalFile.php) does nothing when isHashed() is false.

Because of this purgeThumbnails doesn't do any work, which is obviously bad when an image is updated.

I removed the "if ( $this->isHashed() )" wrapper and the guts of the function seem to work for the non-hashed setup as well (fixed the problem for me, anyway :-)

My suspicion is that the function was bifurcated prior to getThumbPath abstracting the hashing/nohashing pathname and since the major wikis run hashed, nobody's noticed.

Unclear what $this->load() does and if calling it when non-hashed is a problem... I didn't dig into it that deeply.

Cheers,
Jon
Comment 1 Aaron Schulz 2008-05-16 20:21:46 UTC
Fixed in r34935

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links