Last modified: 2010-05-15 15:59:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T15788, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 13788 - getThumbnails broken when not running isHashed
getThumbnails broken when not running isHashed
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.11.x
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-04-18 21:36 UTC by Jon Boede
Modified: 2010-05-15 15:59 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon Boede 2008-04-18 21:36:18 UTC 
The getThumbnails function (LocalFile.php) does nothing when isHashed() is false.

Because of this purgeThumbnails doesn't do any work, which is obviously bad when an image is updated.

I removed the "if ( $this->isHashed() )" wrapper and the guts of the function seem to work for the non-hashed setup as well (fixed the problem for me, anyway :-)

My suspicion is that the function was bifurcated prior to getThumbPath abstracting the hashing/nohashing pathname and since the major wikis run hashed, nobody's noticed.

Unclear what $this->load() does and if calling it when non-hashed is a problem... I didn't dig into it that deeply.

Cheers,
Jon
Comment 1 Aaron Schulz 2008-05-16 20:21:46 UTC 
Fixed in r34935
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links