Last modified: 2014-07-13 08:19:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T15780, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 13780 - Admins don't see when page creations match against the blacklist
Admins don't see when page creations match against the blacklist
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TitleBlacklist (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Jackmcbarn
: patch, patch-reviewed
: 55894 67941 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-17 23:10 UTC by Mike.lifeguard
Modified: 2014-07-13 08:19 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Adds a notification if a user is able to override the blacklist and a title is blacklisted (3.93 KB, patch)
2009-05-03 04:11 UTC, Nakon
Details

Description Mike.lifeguard 2008-04-17 23:10:19 UTC
Administrators don't see matches against the blacklist when creating pages.

When creating a page which does match a regex on the blacklist, administrators should see the same system message, but should additionally be informed that they can create the page anyways. Ideally, they should also be told what protection status the page will have once created. So if that BL entry has <noedit> it will be protected once created. If the entry has <noedit|autoconfirmed> it will be semiprotected. (Assuming I understand how this works correctly!)
Comment 1 X! 2008-04-18 01:18:54 UTC
That can be fixed by putting:

$wgGroupPermissions['sysop']['tboverride'] = false;

in the LocalSettings.php file. 
Comment 2 Mike.lifeguard 2008-04-18 01:25:51 UTC
Sorry, this wasn't clear. I don't want to change whether or not sysops may create blacklisted pages. Rather, I want them to see a warning that "This page is blacklisted against creation do to this entry: ______. You can are overriding the blacklist."

Ideally there would be a further message when <noedit> and/or <autoconfirmed> are present on that blacklist entry: "The page you create will semi/fully protected by the blacklist; change the regex to unprotect it."
Comment 3 Brion Vibber 2008-09-08 22:04:00 UTC
Mm, do you want to force them to confirm and override the warning (like we do with upload warnings) or just toss up a warning message with the "you have created the account yay" message?
Comment 4 Mike.lifeguard 2008-09-08 22:26:50 UTC
Confirm an override would be nice.

I guess this should apply to creating pages as well as accounts (now that <newaccountonly> exists). This was requested before the titleblacklist handled usernames; I was initially concerned only with sysops not seeing that they were creating a salted page (etc).
Comment 5 X! 2008-09-08 22:28:18 UTC
A similar functionality has been added to the user creation form for admin, it could probably be ported over.
Comment 6 Gurch 2008-12-14 15:59:47 UTC
This would be a particularly useful feature to have, as it should hopefully result in faster response times when administrators screw up the title blacklist and block creation of all pages with spaces in their titles, and are blissfully unaware of the situation themselves.
Comment 7 Mike.lifeguard 2008-12-18 04:04:39 UTC
(In reply to comment #2)
> Sorry, this wasn't clear. I don't want to change whether or not sysops may
> create blacklisted pages. Rather, I want them to see a warning that "This page
> is blacklisted against creation do to this entry: ______. You can are
> overriding the blacklist."
> 
> Ideally there would be a further message when <noedit> and/or <autoconfirmed>
> are present on that blacklist entry: "The page you create will semi/fully
> protected by the blacklist; change the regex to unprotect it."
> 

For simple "protection" there may be system messages which could get re-used. Since it's creation, the title blacklist has expanded to affect much more & I suspect a bunch of new system messages may be needed. I wonder whether a generic one with parameters for the action being disallowed and the regex etc could be crafted...
Comment 8 Nakon 2009-05-03 04:11:27 UTC
Created attachment 6082 [details]
Adds a notification if a user is able to override the blacklist and a title is blacklisted

Initial patch.
Comment 9 Sumana Harihareswara 2011-11-14 16:38:59 UTC
Thank you for the patch, Nakon, and sorry that you haven't received a response yet.  I'm marking the patch with "need-review" to signal that this patch awaits review.  Thanks.
Comment 10 bsitu 2012-01-14 01:00:54 UTC
Nakon, thank you for providing the patch, I am sorry that it's taken so long to review the patch, the patch is now obsolete because the file has been modified and the patch is incomplete (undefined class property & unused message key).  You are welcome to revise the patch to work with current trunk.

Thanks,
Comment 11 Krinkle 2012-01-14 02:05:41 UTC
Also note that the AbuseFilter extension may be better at this.
Comment 12 Victor Vasiliev 2012-01-22 12:53:27 UTC
A note on the patch: outputting stuff in the userCan hook is a no-go, this hook may be well used outside any UI.
Comment 13 Victor Vasiliev 2013-10-21 09:11:20 UTC
*** Bug 55894 has been marked as a duplicate of this bug. ***
Comment 14 Gerrit Notification Bot 2014-06-19 17:38:43 UTC
Change 140746 had a related patch set uploaded by Jackmcbarn:
Display a warning when editing a blacklisted page

https://gerrit.wikimedia.org/r/140746
Comment 15 Gerrit Notification Bot 2014-07-10 20:32:34 UTC
Change 140746 merged by jenkins-bot:
Display a warning when editing a blacklisted page

https://gerrit.wikimedia.org/r/140746
Comment 16 Kunal Mehta (Legoktm) 2014-07-13 08:19:34 UTC
*** Bug 67941 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links