Last modified: 2011-11-19 20:01:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T15759, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 13759 - memcached predefined hashes
memcached predefined hashes
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-04-16 09:50 UTC by Zac Bristow
Modified: 2011-11-19 20:01 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
(patched against r33276) (576 bytes, patch)
2008-04-16 09:50 UTC, Zac Bristow 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Zac Bristow 2008-04-16 09:50:25 UTC 
Created attachment 4821 [details]
(patched against r33276)

Some of the methods of the memcached class do not take into account the possibility of predefined hashes for keys [array(hash, key)].  The get_multi method already handles these hashes correctly, and this patch only allows the other methods to do the same.  This does not alter existing behavior for simple string keys.
Comment 1 Zac Bristow 2008-04-16 09:52:00 UTC 
fixed severity - not an enhancement
Comment 2 Siebrand Mazeland 2008-08-18 20:51:38 UTC 
Keywords: need-review, easy.

Will ask Brion to take a quick look at this; patch seems pretty simple.
Comment 3 Brion Vibber 2008-08-18 21:00:14 UTC 
Ugh, this is some scary code. :D

Documentation comments all indicate that $key parameters are to be strings. If arrays are also a possibility, please update the documentation in the class to indicate the proper way to make calls.
Comment 4 Karun 2010-02-06 10:19:39 UTC 
Changed from easy.
Comment 5 Sam Reed (reedy) 2011-11-19 20:01:52 UTC 
r103705
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links