Last modified: 2008-04-16 16:07:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13749 - Position of flagging box in difflinks is inconsistent and not useful
Position of flagging box in difflinks is inconsistent and not useful
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://de.labs.wikimedia.org/
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-15 10:53 UTC by P. Birken
Modified: 2008-04-16 16:07 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description P. Birken 2008-04-15 10:53:53 UTC
This is a bug that I couldn't reproduce, so I do not know when exactly it appears. When logged in as editor, in the difflink http://de.labs.wikimedia.org/w/index.php?title=B%C3%BCrgerwissen_Deutschland/_Grundlinien_deutscher_Geschichte/_Wiedervereinigung&curid=9592&diff=25240&oldid=10688&rcid=1350,  the flagging box appears below the article, whereas in the difflink http://de.labs.wikimedia.org/w/index.php?title=Internationaler_E-Commerce_in_B2C-M%C3%A4rkten/_Logistik&curid=22350&diff=25236&oldid=23457&rcid=1346, the box is above. 

Now, the real point is that for usability, the box should always appear on top of the difflink, so that you can look at the difflink and sight from there. Related bugs are https://bugzilla.wikimedia.org/show_bug.cgi?id=13748 and also the patch subitted by Daniel Arnold for one-click-sighting, https://bugzilla.wikimedia.org/show_bug.cgi?id=13744.
Comment 1 Aaron Schulz 2008-04-15 11:45:20 UTC
The diff against the stable version shows it on top, whereas for other versions, it is on bottom. This is because, if it is not a diff-to-stable, the review is holistic, and requires looking more extensively at the whole page, rather than just the diff.

Nevertheless, it would be easy to make it go on top always.
Comment 2 P. Birken 2008-04-15 17:14:43 UTC
Consistency is important in my eyes. Essentially, there are three possible locations for the box: on top, on the bottom or in the middle after the diff and before the article. I favor the top. Now, I see your point (it's actually something that I have worried aboutt), since the problem is always if two unsighted versions are compared, because then both might be vadalized even if the diff doesn't show vadalism. Therefore, how about the following: show the box on top, but give a warning, if the reference version is unsighted. 
Comment 3 Aaron Schulz 2008-04-16 16:07:37 UTC
Done in r33430

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links