Last modified: 2008-04-16 16:07:37 UTC
This is a bug that I couldn't reproduce, so I do not know when exactly it appears. When logged in as editor, in the difflink http://de.labs.wikimedia.org/w/index.php?title=B%C3%BCrgerwissen_Deutschland/_Grundlinien_deutscher_Geschichte/_Wiedervereinigung&curid=9592&diff=25240&oldid=10688&rcid=1350, the flagging box appears below the article, whereas in the difflink http://de.labs.wikimedia.org/w/index.php?title=Internationaler_E-Commerce_in_B2C-M%C3%A4rkten/_Logistik&curid=22350&diff=25236&oldid=23457&rcid=1346, the box is above. Now, the real point is that for usability, the box should always appear on top of the difflink, so that you can look at the difflink and sight from there. Related bugs are https://bugzilla.wikimedia.org/show_bug.cgi?id=13748 and also the patch subitted by Daniel Arnold for one-click-sighting, https://bugzilla.wikimedia.org/show_bug.cgi?id=13744.
The diff against the stable version shows it on top, whereas for other versions, it is on bottom. This is because, if it is not a diff-to-stable, the review is holistic, and requires looking more extensively at the whole page, rather than just the diff. Nevertheless, it would be easy to make it go on top always.
Consistency is important in my eyes. Essentially, there are three possible locations for the box: on top, on the bottom or in the middle after the diff and before the article. I favor the top. Now, I see your point (it's actually something that I have worried aboutt), since the problem is always if two unsighted versions are compared, because then both might be vadalized even if the diff doesn't show vadalism. Therefore, how about the following: show the box on top, but give a warning, if the reference version is unsighted.
Done in r33430
