Last modified: 2008-04-19 18:18:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13744 - Patch for an adaptive rating form for better usability
Patch for an adaptive rating form for better usability
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
  Show dependency treegraph
Reported: 2008-04-15 01:16 UTC by Daniel Arnold
Modified: 2008-04-19 18:18 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

first version of adaptive rating form (6.80 KB, patch)
2008-04-15 01:16 UTC, Daniel Arnold
second improved version of my patch (14.79 KB, patch)
2008-04-17 18:09 UTC, Daniel Arnold

Description Daniel Arnold 2008-04-15 01:16:15 UTC
Created attachment 4814 [details]
first version of adaptive rating form

The current drop down list rating form of FlaggedRevs is very clumsy in case you have only few available options you can choose from. Especially the anticipated simple setup of de.wikipedia is affected by this. Thus several people have asked for an rating form which adapts automatically to the available options via using radio buttons and check boxes and thus would reduce needed mouse clicks for rating (few mouse clicks is very important for user acceptance).

Below I have attached a patch for FlaggedRevs that provides this.

* The patch fixes as well some usability (see css) and logic glichtes (see e.g. handling of $wgFlagRestrictions review -1 and 0).
* The javascript wasn't patched accordingly and currently thus won't work correctly in case there are radio buttons and/or checkboxes shown. I will do this later (but would like to get this patch applied before).
* In case one option can't be set the entire rating form should be disabled (grey), without needing Javascript. This will fixed done later but is anyways currently the same behaviour as in HEAD, so no merge stopper.
Comment 1 Aaron Schulz 2008-04-15 11:46:19 UTC
Can the JS be updated too?
Comment 2 Daniel Arnold 2008-04-16 00:43:56 UTC
I will fix at first the mentioned problems (in current code and my patch) previous to the javascript in order to be sure that every element is well defined (as the javascript depends from that). Then I will fix the JS file as well afterwards and will upload here a new improved patch the next days.
Comment 3 Aaron Schulz 2008-04-16 04:31:33 UTC
OK, largely patched in for the most part. Not sure about the comment about flaggedrevspage.php needing to be patched.
Comment 4 Daniel Arnold 2008-04-17 18:07:56 UTC
New version of my patch:
* The Javascript is also fixed and now works in all cases (FlaggedRevs.php needed to be patched for this as well).
* In case one flag can't be set the entire form and descriptive texts (see also css file) are disabled entirely without any Javascript (as you can't set any flag anyways). This makes the disabled form more visible and less confusing.
* I have reintroduced my spacing as I think it is better and more flexible (spacing by multiple nbsp isn't that good for own/other/new skins IMHO).
* As well the code was somewhat shortened and some other small cleanups I stumbled at.

One anticipated case is still missing in the adaptive form (the click through link, like on revert) but this depends from a proper fix for #13682 (yet another serverside config variable is needed). I will do this later, as I also need to patch some other parts as well for this (the plugin needs to accept parameters via GET without a further form page on submit).
Comment 5 Daniel Arnold 2008-04-17 18:09:03 UTC
Created attachment 4827 [details]
second improved version of my patch
Comment 6 Aaron Schulz 2008-04-17 22:11:41 UTC
What "click through link"?
Comment 7 Daniel Arnold 2008-04-19 17:30:03 UTC
I meant something like in this old mockup of mine:, the "Unterschied als gesichtet markieren" link.

In case a user can just flag a version as "sighted"/"basic check" and nothing more and no further comment is needed (as suggested for basic flags in [[bug:13682]]) one single link "tag this version with basic check" in case no flag is on this version and in the other case a link "tag this version as  unapproved".
Comment 8 Aaron Schulz 2008-04-19 17:33:02 UTC
OK, but this can still be made as a button. So I don't see a need for modifying it to take GET requests.

At any rate, nice work! It takes a lot less clicks when there is one level and such. Are there any other usability ideas, aside from the one click submit?
Comment 9 Aaron Schulz 2008-04-19 18:18:58 UTC
At any rate, done in r33524. Any other ideas should go in a new patch, if any.

Note You need to log in before you can comment on or make changes to this bug.