Last modified: 2008-04-15 19:02:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13725 - Even if "Add pages I create to my watchlist" is set, uploading an image does not automatically watch it.
Even if "Add pages I create to my watchlist" is set, uploading an image does ...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-13 10:47 UTC by Matthew Flaschen
Modified: 2008-04-15 19:02 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2008-04-13 10:47:52 UTC
To reproduce:

1. Set "Add pages I create to my watchlist" to true in Commons user preferences.
2. Upload an image to Commons.

Expected behavior:

The image description page is automatically watched.

Actual behavior:

The page is not watched.

Either this setting should automatically watch image pages when you upload an image (my preferred solution), or a separate explicit setting for this should be added.
Comment 1 Huji 2008-04-13 18:02:29 UTC
Or, a new option can be added to "Add images I upload to my watchlist", perhaps?
Comment 2 Brion Vibber 2008-04-14 19:35:38 UTC
Works for me.

Both 'Add pages I create to my watchlist' and 'Add pages I edit to my watchlist' seem to do the job, setting the watch checkbox state to on when you start at the upload form.

I confirmed that uploading a new file with the checkbox set adds it to my watchlist.
Comment 3 Matthew Flaschen 2008-04-15 05:59:34 UTC
I figured this out.  When I go to http://commons.wikimedia.org/w/index.php?title=Special:Upload, the watch checkbox is checked, but if I go to http://commons.wikimedia.org/w/index.php?title=Special:Upload&wpDestFile=newimage.jpg it isn't.  It should be checked for both.
Comment 4 Aaron Schulz 2008-04-15 06:11:43 UTC
Odd, the code specifically checks if the dest is empty before checking it. Not sure why...
Comment 5 Aaron Schulz 2008-04-15 06:23:42 UTC
Should be fixed in r33330
Comment 6 Matthew Flaschen 2008-04-15 08:49:42 UTC
Probably because when you click "Upload a new version of this file" you get a URL with wpDestFile set.  The idea of the old code was probably that if wpDestFile is set, it's an "edit" to the image, not a creation.  In my opinion, though, a new version of a file should still count as a creation.

Regardless, wpDestFile does not always indicate a new version at all.  Many tools set it even though there is no existing image.  I originally ran into this issue using flinfo (http://wikipedia.ramselehof.de/flinfo.php) to upload Flickr images.  It will set wpDestFile, though it's a new upload.
Comment 7 Brion Vibber 2008-04-15 19:02:36 UTC
Tweaked it in r33387...

r33330 just disabled the check for wpDestFile, so that the 'watch pages i create'
setting would watch *all* uploads. The system now checks the actual value, so
it sets the watch checkbox if the requested file doesn't exist locally and you
have it set for creations, or if you've already got the file watched.

There are still some minor issues:
* Since you have the chance to change the target filename on the form, the
  initial checkbox state can get out of sync if you switch from an empty file
  to an existing file or vice-versa.
* Unlike the edit form, the upload form doesn't _unwatch_ a previously-watched
  page when the box is unchecked.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links