Last modified: 2008-08-18 21:58:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T15709, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 13709 - Critical error in DynamicPageList2 extension
Critical error in DynamicPageList2 extension
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
DynamicPageList2 (Other open bugs)
unspecified
All All
: Highest critical (vote)
: ---
Assigned To: Nobody - You can work on this!
http://grondin.tuxfamily.org/index.ph...
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-12 10:46 UTC by Bertrand GRONDIN
Modified: 2008-08-18 21:58 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bertrand GRONDIN 2008-04-12 10:46:01 UTC
Fatal error: Call to protected method LinkBatch::executeInto() from context '' in /var/www/wiki/extensions/DynamicPageList2/DynamicPageList2.php on line 1103
Comment 1 Thomas Bleher 2008-04-15 09:09:09 UTC
This patch fixes it:

--- a/includes/LinkBatch.php
+++ b/includes/LinkBatch.php
@@ -72,7 +72,7 @@ class LinkBatch {
         * Do the query and add the results to a given LinkCache object
         * Return an array mapping PDBK to ID
         */
-       protected function executeInto( &$cache ) {
+       public function executeInto( &$cache ) {
                wfProfileIn( __METHOD__ );
                $res = $this->doQuery();
                $ids = $this->addResultToCache( $cache, $res );

"protected" was introduced here in r33025. Not sure why it was done, as both doQuery() and addResultToCache() are public. Suggested fix: Change to "public" as in the patch above.
Comment 2 Siebrand Mazeland 2008-08-18 21:58:46 UTC
This extension no longer exists in the MediaWiki Subversion repository as it was marked obsolete in December 2007 and removed in August 2008. Development has continued for a long while already outside of the repo. This request is now INVALID.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links