Last modified: 2010-05-15 15:38:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1370 - ENotif mails are not automatically reenabled after sent when watching users visits watched and notified page
ENotif mails are not automatically reenabled after sent when watching users v...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.5.x
All All
: Normal normal (vote)
: ---
Assigned To: T. Gries
http://meta.wikipedia.org/Enotif
: patch
Depends on:
Blocks: 1932
  Show dependency treegraph
 
Reported: 2005-01-20 03:01 UTC by T. Gries
Modified: 2010-05-15 15:38 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to reenable ENotifs when watching user visits watched page with changes (1.53 KB, patch)
2005-01-25 02:49 UTC, T. Gries
Details
correction patch (delete a wrong comma) (1.52 KB, patch)
2005-01-25 02:52 UTC, T. Gries
Details
replacement for older patch (1.36 KB, patch)
2005-02-07 06:00 UTC, T. Gries
Details
reminder (to patch in CVS HEAD, please) (1.37 KB, patch)
2005-03-14 21:10 UTC, T. Gries
Details

Description T. Gries 2005-01-20 03:01:35 UTC
ENotif mails are not automatically reenabled after sent when watching users
visits watched and notified page.

The reason is a (currently) misplaced statement $wgUser->clearNotification(
$this->mTitle) in function view() in Article.php . In older versions it works
perfect: the purpose of this statement is to reset the email notification
timestamp for the currently visiting user and the current page (watched) in
table watchlist. This re-enables the next ENotif, when another user changes that
pages later - otherwise it BLOCKS the sending.

The problem at them moment is, that it BLOCKS further sendings, because the
clearNotification is not called when the watching user only visits the page.

I need to move that code further up, but exact tests are needed --> ( to-do-list
Tom )
Tom
- for ENotif

PATCH WILL FOLLOW IN ABOUT ONE DAY
Comment 1 T. Gries 2005-01-25 02:49:15 UTC
Created attachment 222 [details]
Patch to reenable ENotifs when watching user visits watched page with changes

JeLuf or Hashar: please can you commit this to CVS HEAD, otherwise ENotifs are
not reenabled automagically; I still have no CVS HEAD access rights.

Wikinaut Tom
Comment 2 T. Gries 2005-01-25 02:52:19 UTC
Created attachment 223 [details]
correction patch (delete a wrong comma)
Comment 3 T. Gries 2005-02-03 01:54:52 UTC
please, can some apply the patch for me now, I have no CVS access rights.
Comment 4 JeLuF 2005-02-06 19:24:31 UTC
patching file includes/Article.php
Hunk #1 succeeded at 692 (offset 4 lines).
Hunk #2 succeeded at 1786 (offset -12 lines).
patching file includes/User.php
patch: **** malformed patch at line 49:  

Looking at User.php, the context does not match, and I don't have an idea how it
should look like.

Please re-add the "patch" keyword after uploading a new patch.
Comment 5 T. Gries 2005-02-07 06:00:29 UTC
Created attachment 273 [details]
replacement for older patch
Comment 6 T. Gries 2005-03-14 21:10:55 UTC
Created attachment 368 [details]
reminder (to patch in CVS HEAD, please)

patch
Comment 7 Brion Vibber 2005-03-15 07:28:27 UTC
Committed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links