Last modified: 2010-05-15 15:38:30 UTC
ENotif mails are not automatically reenabled after sent when watching users
visits watched and notified page.
The reason is a (currently) misplaced statement $wgUser->clearNotification(
$this->mTitle) in function view() in Article.php . In older versions it works
perfect: the purpose of this statement is to reset the email notification
timestamp for the currently visiting user and the current page (watched) in
table watchlist. This re-enables the next ENotif, when another user changes that
pages later - otherwise it BLOCKS the sending.
The problem at them moment is, that it BLOCKS further sendings, because the
clearNotification is not called when the watching user only visits the page.
I need to move that code further up, but exact tests are needed --> ( to-do-list
- for ENotif
PATCH WILL FOLLOW IN ABOUT ONE DAY
Created attachment 222 [details]
Patch to reenable ENotifs when watching user visits watched page with changes
JeLuf or Hashar: please can you commit this to CVS HEAD, otherwise ENotifs are
not reenabled automagically; I still have no CVS HEAD access rights.
Created attachment 223 [details]
correction patch (delete a wrong comma)
please, can some apply the patch for me now, I have no CVS access rights.
patching file includes/Article.php
Hunk #1 succeeded at 692 (offset 4 lines).
Hunk #2 succeeded at 1786 (offset -12 lines).
patching file includes/User.php
patch: **** malformed patch at line 49:
Looking at User.php, the context does not match, and I don't have an idea how it
should look like.
Please re-add the "patch" keyword after uploading a new patch.
Created attachment 273 [details]
replacement for older patch
Created attachment 368 [details]
reminder (to patch in CVS HEAD, please)