Last modified: 2014-09-23 19:43:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13692 - Use of templates in intersections
Use of templates in intersections
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
DynamicPageList (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-11 08:22 UTC by John Erling Blad
Modified: 2014-09-23 19:43 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Diff for the new feature to use templates for the output from Intersections (2.23 KB, patch)
2008-04-11 08:22 UTC, John Erling Blad
Details
Allow use of templates, uses message cache through method call (2.33 KB, patch)
2008-04-11 18:49 UTC, John Erling Blad
Details

Description John Erling Blad 2008-04-11 08:22:13 UTC
Created attachment 4802 [details]
Diff for the new feature to use templates for the output from Intersections

Attached is a small diff to allow the use of templates for output from the extension intersection. It is tested against version 1.11.0 running PHP: 5.2.1 and MySQL: 5.0.38.

The feature uses a redirect through messages to identified templates, ie the option mode=foo will try to use the content of Mediawiki:Intersection-foo as a template name, prepending the found title with or without namespace and optionally appends the category date as done for links. If the message name isn't defined there will be rendered a template call with something similar to {{<Intersection-foo>|...}}

The extension page on www.mediawiki.org isn't updated.

[[:no:Jeblad]]
Comment 1 John Erling Blad 2008-04-11 08:29:28 UTC
Note that if mode isn't defined the usual behaviour will be retained, also the defined behaviour for mode set to none, ordered, and unordered are retained.

Note also that there should be no impact on performance as long as there are no use of the templates. Due to the redirect through the mediawiki-namespace the evaluation of templates will be somwhat heavier than usual.

[[:no:Jeblad]]
Comment 2 John Erling Blad 2008-04-11 18:49:44 UTC
Created attachment 4806 [details]
Allow use of templates, uses message cache through method call

A sligtly better approach..
[[:no:User:Jeblad]]
Comment 3 Siebrand Mazeland 2010-02-15 10:15:18 UTC
Assign open DynamicPageList issues to new component maintainer.
Comment 4 Sumana Harihareswara 2012-01-14 22:59:15 UTC
John, thanks for the patch.  I'm cc'ing one of the extension's authors to request patch review.
Comment 5 Bawolff (Brian Wolff) 2012-01-15 20:12:32 UTC
Thank you for the patch. However, I don't think this is the right way of implementing this feature for several reasons:

- Shouldn't use the borderline private methods of message cache
- Questionable weather the template should be a specified in such an indirect way (Specify name, which resolves to a system message, which resolves back to a template, seems as if it should just directly take the template. I like mode=template, templatename=foo approach much better personally)
- Some coding convention issues (but those issues are more reflective of the extension in general then of this patch).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links