Last modified: 2010-05-15 15:38:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1369 - ENotifs mail come with wrong "oldid" revision numbers (one version too late)
ENotifs mail come with wrong "oldid" revision numbers (one version too late)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.5.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-01-20 02:21 UTC by T. Gries
Modified: 2010-05-15 15:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2005-01-20 02:21:05 UTC
Due to database redesign, this tiny change must be applied to let the Enotif mails come with the _correct_ link to 
the diff between the last-visited-revision and the current revision. (Currently, the mail come with a pointer to 
the diff between the first-not-yet-seen and the current revision, which makes no sense. This small bug was 
apparently introduced during the recent database redesign but appears to be solved with this small patch). 
 
Tom 
- for ENotif 
 
Please (JeLuF or Hashar) can you fix this for me, thanks. I do not have CVS access rights. 
 
RCS file: /cvsroot/wikipedia/phase3/includes/Article.php,v 
retrieving revision 1.262 
diff -u -b -r1.262 Article.php 
--- includes/Article.php	19 Jan 2005 03:54:43 -0000	1.262 
+++ includes/Article.php	20 Jan 2005 02:12:22 -0000 
@@ -1040,7 +1040,7 @@ 
 			$u->doUpdate(); 
 		} 
 
-		$this->showArticle( $text, wfMsg( 'updated' ), $sectionanchor, $me2, $now, $summary, $revisionId ); 
+		$this->showArticle( $text, wfMsg( 'updated' ), $sectionanchor, $me2, $now, $summary, 
$lastRevision ); // old_id fix for new database scheme 
 		} 
 		return $good; 
 	}
Comment 1 JeLuF 2005-01-22 10:14:40 UTC
Fixed in rev 1.263

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links