Last modified: 2008-12-09 13:31:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13662 - log events in IRC RC feed not backward compatible/broke bots
log events in IRC RC feed not backward compatible/broke bots
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 16599
  Show dependency treegraph
 
Reported: 2008-04-08 19:13 UTC by slakr
Modified: 2008-12-09 13:31 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description slakr 2008-04-08 19:13:24 UTC
I'm not sure what the format originally was, but it appears that recently the IRC rc feed changed something about its log event messages (I'm guessing made it shorter?), such that it breaks pgkbots and presumably other bots that might be monitoring for uploads, blocks, new user creates, and other logevents (though normal edits seem to be parsed fine).  I'd provide more info by jumbling through the source, but I'm not a huge python fan :P

Thanks a million, and cheers =)

--slakr@enwiki
Comment 1 Igor Remolar @ Betxí 2008-04-10 21:30:54 UTC
I think that changes break certain parsings. For example, before, in the move log, we can parse the old page and the new page. Now, the new page doesn't appear in the IRC rc message. This situation borrow to make a request to the server to know where the old page redirects.

--Pasqual@cawiki
Comment 2 Igor Remolar @ Betxí 2008-04-10 21:33:12 UTC
(In reply to comment #1)
> I think that changes break certain parsings. For example, before, in the move
> log, we can parse the old page and the new page. Now, the new page doesn't
> appear in the IRC rc message. This situation borrow to make a request to the
> server to know where the old page redirects.
> 
> --Pasqual@cawiki
> 

not ''borrow'', but '''oblige''', '''force'''
Comment 3 Filip Maljkovic [Dungodung] 2008-04-12 09:07:58 UTC
Also, a user rights change doesn't include the actual rights that have been changed anymore.
Backwards compatibility isn't as much important to me as the availability of standard data :)
Comment 4 Tim Starling 2008-04-16 21:27:29 UTC
Assigning to Aaron Schultz, I assume it's related to his changes in that area. It would be nice if he could test the IRC output, say by using a test setup that sends data to the debug log instead of UDP. Backwards compatibility most certainly should not be the aim with this particular output format, but it should look nice and give lots of information.
Comment 5 Aaron Schulz 2008-04-18 16:13:11 UTC
Not at all familiar with this IRC output. Where is the code for this stuff anyway? 
Comment 6 Casey Brown 2008-04-18 20:44:59 UTC
(In reply to comment #5)
> Not at all familiar with this IRC output. Where is the code for this stuff
> anyway? 
> 

https://wikitech.leuksman.com/view/IRCD might be a good place to start.
Comment 7 Aaron Schulz 2008-04-20 14:33:19 UTC
Fixed in r33629.
Comment 8 Platonides 2008-04-20 14:46:47 UTC
I had to fix a upload bot about it:

Old syntax was 
[[Special:Log/upload]] upload * <User> *  uploaded "[[Image:<Image>]]": <Description>
Now it is:
[[Image:<Image>]] upload  * <User> * <Description>

But i think this is the proper way to do it. The first parameter is the target. Those actions on Special:Log only made special cases you needed to treat separatedly.
The bots will obviously need to be updated but it was never a stable interface. You equally need to update when the action upload was splitted into "upload" and "overwrite".

The only desirable thing would be sending an email to wikibots-l when changing the format, so bot authors can prepare the code for next scap.
Comment 9 Platonides 2008-04-21 22:54:13 UTC
It wasn't really. Originally it was 
<Color>14[[<Color>07Special:Log/upload<Color>14]]<Color>4 upload<Color>10 <Color>02<Color> <Color>5*<Color> <Color>03<User><Color> <Color>5*<Color>  <Color>10uploaded "[[<Color>02Image:<Image><Color>10]]": <Description>

Not it is:
<Color>14[[<Color>07Special:Log/upload<Color>14]]<Color>4 upload<Color>10 <Color>02<Color> <Color>5*<Color> <Color>03<User><Color> <Color>5*<Color>  <Color>10uploaded "[[Image:<Image>]]": <Description>

Ie. The target filename is no longer blue, which was the handy way to get the action target.
Comment 10 Aaron Schulz 2008-04-21 23:00:09 UTC
Fixed in r33697

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links